Exposed again the pipelines queue.data and queue.capacity subdocuments for _node/stats#11923
Merged
andsel merged 1 commit intoelastic:masterfrom Jun 4, 2020
Conversation
2 tasks
This was referenced May 26, 2020
jsvd
reviewed
May 27, 2020
Member
jsvd
left a comment
There was a problem hiding this comment.
To not break anything published, this PR does the merge of both, duplicating some data
Can you elaborate here on what gets duplicated with this change?
Contributor
Author
|
After this change for a persisted queue the "queue": {
"data": {
"storage_type": "ext4",
"path": "/home/andrea/workspace/logstash_andsel/data/queue/main",
"free_space_in_bytes": 58074423296
},
"capacity": {
"page_capacity_in_bytes": 67108864,
"queue_size_in_bytes": 335, *
"max_unread_events": 0,
"max_queue_size_in_bytes": 1073741824 **
},
"events": 0, ***
"type": "persisted",
"events_count": 0, ***
"queue_size_in_bytes": 335, *
"max_queue_size_in_bytes": 1073741824 **
},
"hash": "3ff22011c5f904fd46f676f1392cbb1914b9f2e463af0fee296a74ed0df9a147",
"ephemeral_id": "3dd64d86-2373-4f53-afbd-7e1a7c1f23e2"
}where the |
…s for _node/stats Avoid to reassing the subdocument for queue metrics preferring a merge With PR elastic#10576 the PluginsStats.report(stats) overwrites the subsection related to queue instead of merge with newly created entries.
25f3214 to
7ea71b5
Compare
This was referenced Jun 4, 2020
This was referenced Jun 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid to reassign the subdocument for queue metrics preferring a merge
With PR #10576 the PluginsStats.report(stats) overwrites the subsection related to queue instead of merge with newly created entries.
With the overwriting of
queuesubdocument the HTTP withextended_statsreturn something likeinstead of the original form:
To not break anything published, this PR does the merge of both, duplicating some data