Pass FEATURE_FLAG as Docker environment variable#11922
Merged
andsel merged 1 commit intoelastic:masterfrom Jun 4, 2020
Merged
Conversation
Contributor
Author
|
This PR makes the build fail,it should be merged on master after the fix to the document exposed by HTTP API |
2 tasks
jsvd
reviewed
May 25, 2020
ci/docker_integration_tests.sh
Outdated
Comment on lines
+2
to
+4
| if [ -n "${FEATURE_FLAG}" ]; then | ||
| export DOCKER_ENV_OPTS="${DOCKER_ENV_OPTS} --env FEATURE_FLAG=${FEATURE_FLAG}" | ||
| fi |
Member
There was a problem hiding this comment.
This should be enough, naming only the env var will use its value by default, and we don't need to check if it's set. If it's not then the container wont have it as well
Suggested change
| if [ -n "${FEATURE_FLAG}" ]; then | |
| export DOCKER_ENV_OPTS="${DOCKER_ENV_OPTS} --env FEATURE_FLAG=${FEATURE_FLAG}" | |
| fi | |
| # we may pass "persistent_queues" to FEATURE_FLAG to enable PQ in the integration tests | |
| export DOCKER_ENV_OPTS="${DOCKER_ENV_OPTS} -e FEATURE_FLAG" |
b9beda5 to
6b8fce9
Compare
Some QA tests reads the FEATURE_FLAG environment variable, for example to test PQ functionality. This PR passthrough the environement variable inside the Docker instance.
6b8fce9 to
65b76cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some QA tests reads the FEATURE_FLAG environment variable, for example to test PQ functionality.
This PR passthrough the environement variable inside the Docker instance.
To run it locally use: