Skip to content

[Maps] fix fit to data on heatmap not working#92697

Merged
nreese merged 3 commits intoelastic:masterfrom
nreese:issue_92288
Mar 1, 2021
Merged

[Maps] fix fit to data on heatmap not working#92697
nreese merged 3 commits intoelastic:masterfrom
nreese:issue_92288

Conversation

@nreese
Copy link
Copy Markdown
Contributor

@nreese nreese commented Feb 24, 2021 •
edited
Loading

Fixes #92288 and #92657

#90666 refactored HeatmapLayer from extending VectorLayer to just extending AbstractLayer. Several methods that were implemented on VectorLayer are not implemented on HeatmapLayer. Not having getBounds caused #92288. Not having getQueryableIndexPatternIds caused #92657.

This PR does an complete audit on ILayer methods and ensures any method with a customized implementation in VectorLayer is has its implementation migrated to HeatmapLayer

@nreese nreese added Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v7.13.0 labels Feb 24, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 24, 2021

Pinging @elastic/kibana-gis (Team:Geo)

@nreese
Copy link
Copy Markdown
Contributor Author

nreese commented Mar 1, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 1, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.7MB 2.7MB +799.0B
triggersActionsUi 1.6MB 1.5MB -23.9KB
total -23.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 104.0KB 104.1KB +82.0B
Unknown metric groups

async chunk count

id before after diff
triggersActionsUi 41 42 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thomasneirynck thomasneirynck self-requested a review March 1, 2021 19:33
thomasneirynck
thomasneirynck approved these changes Mar 1, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for fixing

@nreese nreese merged commit d02294c into elastic:master Mar 1, 2021
@nreese nreese mentioned this pull request Mar 1, 2021
Closed
nreese added a commit to nreese/kibana that referenced this pull request Mar 1, 2021
@nreese @kibanamachine
[Maps] fix fit to data on heatmap not working (elastic#92697)
7272f2c 
* [Maps] fix fit to data on heatmap not working

* tslint

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@nreese nreese mentioned this pull request Mar 1, 2021
Merged
nreese added a commit to nreese/kibana that referenced this pull request Mar 1, 2021
@nreese @kibanamachine
[Maps] fix fit to data on heatmap not working (elastic#92697)
3076f7e 
* [Maps] fix fit to data on heatmap not working

* tslint

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@nreese nreese mentioned this pull request Mar 1, 2021
Merged
nreese added a commit that referenced this pull request Mar 1, 2021
@nreese @kibanamachine
[Maps] fix fit to data on heatmap not working (#92697) (#93113)
8c72812 
* [Maps] fix fit to data on heatmap not working

* tslint

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
nreese added a commit that referenced this pull request Mar 1, 2021
@nreese @kibanamachine
[Maps] fix fit to data on heatmap not working (#92697) (#93112)
3df7f57 
* [Maps] fix fit to data on heatmap not working

* tslint

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
jloleysens added a commit that referenced this pull request Mar 3, 2021
@jloleysens
Merge branch 'ilm/rollup-v2-action' of github.com:elastic/kibana into…
50eed10 
… ilm/rollup-v2-action

* 'ilm/rollup-v2-action' of github.com:elastic/kibana: (30 commits)
  Fix expanding document when using saved search data grid (#92999)
  [SECURITY SOLUTIONS] Bug case connector (#93104)
  [Security Solution] [Timeline] Bugfix to include unmapped fields in the timeline event details JSON (#92025)
  [Alerting][Docs] Changed alerting documentation to point to a single source of explaining the configurations. (#92942)
  [APM] Fix hidden search bar in error pages while loading (#84476) (#93139)
  [DOCS] Fixes links for machine learning alerts (#92744)
  [Security Solution][Detections] -Fixes rule edit flow bug with max_signals (#92748)
  [SecuritySolution][Case] Disable cases on detections in read-only mode (#93010)
  [Security Solution][Case][Bug] Prevent closing collection when pushing (#93095)
  [Security Solution][Detections][7.12] Critical Threshold Rule Fixes (#92667)
  Bump ems landing page to 7.12 (#93065)
  [App Search] Implement various Relevance Tuning states and form actions (#92644)
  [actions] for simplistic email servers, set rejectUnauthorized to false (#91760)
  [Security Solution][Case] Migrate category & subcategory fields of ServiceNow ITSM connector (#93092)
  Hide instances latency distribution chart (#92869)
  [Maps] fix MapboxDraw import from pointing to dist just pointing to folder (#93087)
  [Maps] fix results trimmed tooltip message doubles feature count for line and polygon features (#92932)
  [Security Solution][Detecttions] Indicator enrichment tweaks (#92989)
  [Maps] fix fit to data on heatmap not working (#92697)
  [Security Solution][Endpoint][Admin] Fixes policy sticky footer save test (#92919)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@thomasneirynck thomasneirynck thomasneirynck approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.12.0 v7.13.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Maps] Fit to data on heatmap not working

4 participants

@nreese @elasticmachine @kibanamachine @thomasneirynck