Skip to content

[Maps] convert HeatmapLayer to TS#90666

Merged
nreese merged 6 commits intoelastic:masterfrom
nreese:heatmap_layer
Feb 9, 2021
Merged

[Maps] convert HeatmapLayer to TS#90666
nreese merged 6 commits intoelastic:masterfrom
nreese:heatmap_layer

Conversation

@nreese
Copy link
Copy Markdown
Contributor

@nreese nreese commented Feb 8, 2021

Converts HeatmapLayer to TS. HeatmapLayer not longer extends VectorLayer

@nreese nreese added chore Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Feb 8, 2021
@nreese nreese requested a review from thomasneirynck February 8, 2021 18:30
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese
Copy link
Copy Markdown
Contributor Author

nreese commented Feb 9, 2021

@elasticmachine merge upstream

Copy link
Copy Markdown
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@@ -0,0 +1,114 @@
/*
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thx for extracting

@nreese
Copy link
Copy Markdown
Contributor Author

nreese commented Feb 9, 2021

@elasticmachine merge upstream

@nreese
Copy link
Copy Markdown
Contributor Author

nreese commented Feb 9, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
maps 689 692 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.6MB 2.6MB +997.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit a9ee83c into elastic:master Feb 9, 2021
nreese added a commit to nreese/kibana that referenced this pull request Feb 9, 2021
* [Maps] convert HeatmapLayer to TS

* make VectorLayer implement IVectorLayer

* fix jest test and functional test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
nreese added a commit that referenced this pull request Feb 10, 2021
* [Maps] convert HeatmapLayer to TS

* make VectorLayer implement IVectorLayer

* fix jest test and functional test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore release_note:skip Skip the PR/issue when compiling release notes Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.12.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants