Put environment back in uiFilters#92561
Merged
smith merged 1 commit intoelastic:masterfrom Feb 24, 2021
Merged
Conversation
`environment` is still used in `uiFilters` in UX, but not anywhere else. It was removed when removing environment from UI filters for the rest of APM and broke UX's environment switcher. Put it back.
Contributor
|
Pinging @elastic/apm-ui (Team:apm) |
Contributor
💔 Backport failed❌ 7.12: Commit could not be cherrypicked due to conflicts To backport manually, check out the target branch and run: |
smith
added a commit
to smith/kibana
that referenced
this pull request
Feb 24, 2021
`environment` is still used in `uiFilters` in UX, but not anywhere else. It was removed when removing environment from UI filters for the rest of APM and broke UX's environment switcher. Put it back. # Conflicts: # x-pack/plugins/apm/public/context/url_params_context/url_params_context.tsx
smith
added a commit
to smith/kibana
that referenced
this pull request
Feb 24, 2021
`environment` is still used in `uiFilters` in UX, but not anywhere else. It was removed when removing environment from UI filters for the rest of APM and broke UX's environment switcher. Put it back. # Conflicts: # x-pack/plugins/apm/public/context/url_params_context/url_params_context.tsx
smith
added a commit
that referenced
this pull request
Feb 24, 2021
`environment` is still used in `uiFilters` in UX, but not anywhere else. It was removed when removing environment from UI filters for the rest of APM and broke UX's environment switcher. Put it back. # Conflicts: # x-pack/plugins/apm/public/context/url_params_context/url_params_context.tsx
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 25, 2021
…bana into task-manager/docs-monitoring * 'task-manager/docs-monitoring' of github.com:gmmorris/kibana: (120 commits) Bump the CI Node.js version from 14.15.4 to 14.16.0 (elastic#92578) [Uptime] Search made easy (elastic#88581) [Lens] Stop requesting stats on Records field (elastic#92508) [APM] Correlations style polish in prep for release (elastic#92514) [Lens] Fix sorting undefined, null and NaN values (elastic#92575) Put environment back in uiFilters (elastic#92561) [Discover] Fix sorting by _score behavior (elastic#92132) Add metricbeat steps to jenkins_build_load_testing.sh (elastic#90290) [Usage Collection] Remove unused UI Metric APIs (elastic#91620) Fix timelion deprecation documentation links (elastic#92576) [TSVB] Enable `dual mode`, support index patterns and strings (elastic#92395) Fix text align in Safari (elastic#92374) [Actions][Doc] Clean up Actions README (elastic#91789) chore(NA): add missing files to exclude when building bazel prod packages (elastic#92506) [Security Solution][Endpoint][Admin] Match Policy Details in Security Solution with Fleet (elastic#92047) Revert "[build] Add task skips intended for partial builds (elastic#92076)" [Enterprise Search] Change icon for error in EuiCallouts (elastic#92527) [Alerts][Docs] Alert types doc update. Added refs to applications specific alerts groups. (elastic#91787) [Security Solution][Exceptions] - Update exceptions modal to use existing lists plugin useApi hook (elastic#92348) [DOCS] Updates refresh text in index pattern doc (elastic#92469) ...
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
smith
added a commit
that referenced
this pull request
Feb 27, 2021
`environment` is still used in `uiFilters` in UX, but not anywhere else. It was removed when removing environment from UI filters for the rest of APM and broke UX's environment switcher. Put it back. # Conflicts: # x-pack/plugins/apm/public/context/url_params_context/url_params_context.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
environmentis still used inuiFiltersin UX, but not anywhere else.It was removed when removing environment from UI filters for the rest of APM and broke UX's environment switcher. Put it back.