[Discover] Fix sorting by _score behavior#92132
Merged
kertal merged 7 commits intoelastic:masterfrom Feb 24, 2021
Merged
Conversation
Member
Author
|
@elasticmachine merge upstream |
Member
Author
|
@elasticmachine merge upstream |
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
wylieconlon
approved these changes
Feb 22, 2021
Contributor
wylieconlon
left a comment
There was a problem hiding this comment.
I tested this and compared against 7.11- it seems like this was already the default behavior before?
Anyway LGTM, but probably needs a second reviewer
Member
Author
it was, but due to changes after 7.11 it wasn't anymore, so I might rewrite the title 'Improve' which is misleading |
1 task
Member
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @kertal |
majagrubic
approved these changes
Feb 24, 2021
Contributor
majagrubic
left a comment
There was a problem hiding this comment.
Tested it and works correctly (also not clear to me when was it removed in the first place).
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Feb 24, 2021
kertal
added a commit
that referenced
this pull request
Feb 24, 2021
kertal
added a commit
that referenced
this pull request
Feb 24, 2021
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 25, 2021
…bana into task-manager/docs-monitoring * 'task-manager/docs-monitoring' of github.com:gmmorris/kibana: (120 commits) Bump the CI Node.js version from 14.15.4 to 14.16.0 (elastic#92578) [Uptime] Search made easy (elastic#88581) [Lens] Stop requesting stats on Records field (elastic#92508) [APM] Correlations style polish in prep for release (elastic#92514) [Lens] Fix sorting undefined, null and NaN values (elastic#92575) Put environment back in uiFilters (elastic#92561) [Discover] Fix sorting by _score behavior (elastic#92132) Add metricbeat steps to jenkins_build_load_testing.sh (elastic#90290) [Usage Collection] Remove unused UI Metric APIs (elastic#91620) Fix timelion deprecation documentation links (elastic#92576) [TSVB] Enable `dual mode`, support index patterns and strings (elastic#92395) Fix text align in Safari (elastic#92374) [Actions][Doc] Clean up Actions README (elastic#91789) chore(NA): add missing files to exclude when building bazel prod packages (elastic#92506) [Security Solution][Endpoint][Admin] Match Policy Details in Security Solution with Fleet (elastic#92047) Revert "[build] Add task skips intended for partial builds (elastic#92076)" [Enterprise Search] Change icon for error in EuiCallouts (elastic#92527) [Alerts][Docs] Alert types doc update. Added refs to applications specific alerts groups. (elastic#91787) [Security Solution][Exceptions] - Update exceptions modal to use existing lists plugin useApi hook (elastic#92348) [DOCS] Updates refresh text in index pattern doc (elastic#92469) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The integration of EuiDataGrid made it necessary to allow the user to un-sort Discover's document table. (#85561) Default sorting of index patterns without time field sorted internally still by
_score, but when the user added the_scorecolumn, there was no indication that's it's sorted. This PR solves it by automatically adding sorting by_scorewhen the user selects the column, if she/he didn't sort it before by a different field. This also works when adding _score using an index pattern with timefield and it's in an unsorted state. Also this PR increased test coverageTesting
_scorecolumnsort_by_score.mp4
Checklist