[Security Solution][Exceptions] - Update exceptions modal to use existing lists plugin useApi hook#92348
Merged
yctercero merged 5 commits intoelastic:masterfrom Feb 23, 2021
Merged
Conversation
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Contributor
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/ingest_pipelines/feature_controls/ingest_pipelines_security·ts.Ingest pipelines app feature controls security global dashboard read with ingest_pipelines_user should render the "Ingest" section with ingest pipelinesStandard OutStack TraceMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @yctercero |
dplumlee
approved these changes
Feb 23, 2021
Contributor
dplumlee
left a comment
There was a problem hiding this comment.
looks good, nice refactor
yctercero
added a commit
to yctercero/kibana
that referenced
this pull request
Feb 23, 2021
…ting lists plugin useApi hook (elastic#92348) Doing a quick refactor to help with elastic#90634 . While working on elastic#90634 found that I would introduce a circular dependency if I didn't refactor the hook used by the exception builder component to make use of the existing useApi hook in the lists plugin. elastic#90634 adds temporary ids to item entries to mitigate some React key requirements and the logic to remove/add these id's isn't at the boundary but in the hooks (so as not to pollute the data for everyone wanting to use the api. An upside is that it removed some of the looping and seemed to speed things up a bit. I briefly considered adding the bulk SO endpoints for exception items, but they are still experimental.
yctercero
added a commit
to yctercero/kibana
that referenced
this pull request
Feb 23, 2021
…ting lists plugin useApi hook (elastic#92348) Doing a quick refactor to help with elastic#90634 . While working on elastic#90634 found that I would introduce a circular dependency if I didn't refactor the hook used by the exception builder component to make use of the existing useApi hook in the lists plugin. elastic#90634 adds temporary ids to item entries to mitigate some React key requirements and the logic to remove/add these id's isn't at the boundary but in the hooks (so as not to pollute the data for everyone wanting to use the api. An upside is that it removed some of the looping and seemed to speed things up a bit. I briefly considered adding the bulk SO endpoints for exception items, but they are still experimental.
yctercero
added a commit
that referenced
this pull request
Feb 24, 2021
…ting lists plugin useApi hook (#92348) (#92534) Doing a quick refactor to help with #90634 . While working on #90634 found that I would introduce a circular dependency if I didn't refactor the hook used by the exception builder component to make use of the existing useApi hook in the lists plugin. #90634 adds temporary ids to item entries to mitigate some React key requirements and the logic to remove/add these id's isn't at the boundary but in the hooks (so as not to pollute the data for everyone wanting to use the api. An upside is that it removed some of the looping and seemed to speed things up a bit. I briefly considered adding the bulk SO endpoints for exception items, but they are still experimental.
yctercero
added a commit
that referenced
this pull request
Feb 24, 2021
…ting lists plugin useApi hook (#92348) (#92535) Doing a quick refactor to help with #90634 . While working on #90634 found that I would introduce a circular dependency if I didn't refactor the hook used by the exception builder component to make use of the existing useApi hook in the lists plugin. #90634 adds temporary ids to item entries to mitigate some React key requirements and the logic to remove/add these id's isn't at the boundary but in the hooks (so as not to pollute the data for everyone wanting to use the api. An upside is that it removed some of the looping and seemed to speed things up a bit. I briefly considered adding the bulk SO endpoints for exception items, but they are still experimental.
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 25, 2021
…bana into task-manager/docs-monitoring * 'task-manager/docs-monitoring' of github.com:gmmorris/kibana: (120 commits) Bump the CI Node.js version from 14.15.4 to 14.16.0 (elastic#92578) [Uptime] Search made easy (elastic#88581) [Lens] Stop requesting stats on Records field (elastic#92508) [APM] Correlations style polish in prep for release (elastic#92514) [Lens] Fix sorting undefined, null and NaN values (elastic#92575) Put environment back in uiFilters (elastic#92561) [Discover] Fix sorting by _score behavior (elastic#92132) Add metricbeat steps to jenkins_build_load_testing.sh (elastic#90290) [Usage Collection] Remove unused UI Metric APIs (elastic#91620) Fix timelion deprecation documentation links (elastic#92576) [TSVB] Enable `dual mode`, support index patterns and strings (elastic#92395) Fix text align in Safari (elastic#92374) [Actions][Doc] Clean up Actions README (elastic#91789) chore(NA): add missing files to exclude when building bazel prod packages (elastic#92506) [Security Solution][Endpoint][Admin] Match Policy Details in Security Solution with Fleet (elastic#92047) Revert "[build] Add task skips intended for partial builds (elastic#92076)" [Enterprise Search] Change icon for error in EuiCallouts (elastic#92527) [Alerts][Docs] Alert types doc update. Added refs to applications specific alerts groups. (elastic#91787) [Security Solution][Exceptions] - Update exceptions modal to use existing lists plugin useApi hook (elastic#92348) [DOCS] Updates refresh text in index pattern doc (elastic#92469) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Doing a quick refactor to help with #90634 . While working on #90634 found that I would introduce a circular dependency if I didn't refactor the hook used by the exception builder component to make use of the existing
useApihook in the lists plugin.#90634 adds temporary
ids to item entries to mitigate some React key requirements and the logic to remove/add these id's isn't at the boundary but in the hooks (so as not to pollute the data for everyone wanting to use the api.An upside is that it removed some of the looping and seemed to speed things up a bit. I briefly considered adding the bulk SO endpoints for exception items, but they are still experimental.
Checklist