Skip to content

Visualizations without spy panels causing error messages#9115

Merged
ppisljar merged 1 commit intoelastic:masterfrom
ppisljar:fix/9102
Nov 21, 2016
Merged

Visualizations without spy panels causing error messages#9115
ppisljar merged 1 commit intoelastic:masterfrom
ppisljar:fix/9102

Conversation

@ppisljar
Copy link
Copy Markdown
Contributor

Visualizations without spy panels causing error messages

Fixes #9102

Visualize is trying to adjust the view of vis spy panel, but Timelion doesn't have a spy.

UPDATE: This error happens on Dashboard as well.

UPDATE2: This actually happens with any visualization that doesn't have a spy panel, which includes the Markdown panel.

2c739804-abe9-11e6-9753-26aa178421d2

@tbragin tbragin added the Feature:Visualizations Generic visualization features (in case no more specific feature label is available) label Nov 18, 2016
Copy link
Copy Markdown
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Peter.

LGTM

@w33ble
Copy link
Copy Markdown
Contributor

w33ble commented Nov 21, 2016

Sorry for the delay on my end. Everything seems to be working as expected, but the error is gone here. LGTM!

@ppisljar ppisljar merged commit 5ef7a52 into elastic:master Nov 21, 2016
elastic-jasper added a commit that referenced this pull request Nov 21, 2016
Backports PR #9115

**Commit 1:**
fixing error when vis has no spy panel

* Original sha: c47f849
* Authored by ppisljar <peter.pisljar@gmail.com> on 2016-11-17T11:39:29Z
ppisljar pushed a commit that referenced this pull request Nov 21, 2016
Backports PR #9115

**Commit 1:**
fixing error when vis has no spy panel

* Original sha: c47f849
* Authored by ppisljar <peter.pisljar@gmail.com> on 2016-11-17T11:39:29Z
ppisljar added a commit that referenced this pull request Nov 21, 2016
Backports PR #9115

**Commit 1:**
fixing error when vis has no spy panel

* Original sha: c47f849
* Authored by ppisljar <peter.pisljar@gmail.com> on 2016-11-17T11:39:29Z
ppisljar pushed a commit that referenced this pull request Nov 21, 2016
Backports PR #9115

**Commit 1:**
fixing error when vis has no spy panel

* Original sha: c47f849
* Authored by ppisljar <peter.pisljar@gmail.com> on 2016-11-17T11:39:29Z
@epixa epixa added v5.1.1 and removed v5.1.0 labels Dec 8, 2016
airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017
Backports PR elastic#9115

**Commit 1:**
fixing error when vis has no spy panel

* Original sha: c47f849
* Authored by ppisljar <peter.pisljar@gmail.com> on 2016-11-17T11:39:29Z

Former-commit-id: 567d636
acstll added a commit that referenced this pull request Oct 23, 2025
- `@elastic/eui`: `v107.0.0` ⏩ `v107.0.1`
- `@elastic/eslint-plugin-eui`: `v2.4.0` ⏩ `v2.5.0`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

---

## Changes

Related to elastic/eui#9100

- Updated snapshot f90ae29
- Added missing `aria-label` for `EuiBetaBadge`
  - [Reporting] 6d10edd
  - [ML] ce58009
- Added new translation key, ran `node scripts/i18n_check` — is there
anything else that should be done in this regard?

## Package updates

### `@elastic/eui`
[`v107.0.1`](https://github.com/elastic/eui/releases/v107.0.1)

**Bug fixes**

- Fixed `prismjs` theme in `EuiCodeBlock` to improve highlighting for
the `yaml` language ([#9089](elastic/eui#9089))
- Fixed a visual bug on `EuiTable` where the border for rows in dark
mode wasn't applied correctly
([#9115](elastic/eui#9115))

**Dependency updates**

- Updated `@elastic/prismjs-esql` to v1.1.2
([#9102](elastic/eui#9102))

**Accessibility**

- Fixed incorrect role attribute on `EuiIcon` and `EuiBetaBadge`
([#9100](elastic/eui#9100))
- Make `EuiBasicTable` respect user's reduced motion setting by not
animating when in loading state.
([#9095](elastic/eui#9095))

### `@elastic/eslint-plugin-eui`
[`v2.5.0`](https://github.com/elastic/eui/blob/main/packages/eslint-plugin/changelogs/CHANGELOG_2025.md#v250)

- Added new `accessible-interactive-element` rule.
([#9093](elastic/eui#9093))
- Added new `tooltip-focusable-anchor` rule.
([#9051](elastic/eui#9051))
- Excluded `EuiButtonEmpty` from the `no-unnamed-interactive-element`
rule. ([#9046](elastic/eui#9046))

**Bug fixes**

- Fixed `no-css-color` rule to allow CSS keywords like `currentcolor`,
`transparent`, and `inherit`
([#9092](elastic/eui#9092))

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review v5.0.2 v5.1.1 v6.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants