Skip to content

Encode embedded loading logo SVG to work in Firefox.#9089

Merged
cjcenizal merged 1 commit intoelastic:masterfrom
cjcenizal:bug/loading-logo-svg-firefox
Nov 16, 2016
Merged

Encode embedded loading logo SVG to work in Firefox.#9089
cjcenizal merged 1 commit intoelastic:masterfrom
cjcenizal:bug/loading-logo-svg-firefox

Conversation

@cjcenizal
Copy link
Copy Markdown
Contributor

@cjcenizal cjcenizal commented Nov 15, 2016

This solves the bug where the logo on the loading screen wasn't showing up in Firefox.

image

Description of the technical cause of the problem and solution: http://stackoverflow.com/questions/28588050/how-to-use-a-hex-value-for-svg-in-firefox

@cjcenizal cjcenizal added bug Fixes for quality problems that affect the customer experience v5.1.0 v6.0.0 labels Nov 15, 2016
@epixa
Copy link
Copy Markdown
Contributor

epixa commented Nov 16, 2016

screen shot 2016-11-15 at 8 35 02 pm

LGTM

@cjcenizal cjcenizal merged commit 1f5d6c8 into elastic:master Nov 16, 2016
@cjcenizal cjcenizal deleted the bug/loading-logo-svg-firefox branch November 16, 2016 18:12
elastic-jasper added a commit that referenced this pull request Nov 16, 2016
Backports PR #9089

**Commit 1:**
Encode embedded loading logo SVG to work in Firefox.

* Original sha: c68492b
* Authored by CJ Cenizal <cj@cenizal.com> on 2016-11-15T22:42:21Z
cjcenizal pushed a commit that referenced this pull request Nov 16, 2016
Backports PR #9089

**Commit 1:**
Encode embedded loading logo SVG to work in Firefox.

* Original sha: c68492b
* Authored by CJ Cenizal <cj@cenizal.com> on 2016-11-15T22:42:21Z
@epixa epixa added v5.1.1 and removed v5.1.0 labels Dec 8, 2016
airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017
Backports PR elastic#9089

**Commit 1:**
Encode embedded loading logo SVG to work in Firefox.

* Original sha: c68492b
* Authored by CJ Cenizal <cj@cenizal.com> on 2016-11-15T22:42:21Z

Former-commit-id: ac93aba
acstll added a commit that referenced this pull request Oct 23, 2025
- `@elastic/eui`: `v107.0.0` ⏩ `v107.0.1`
- `@elastic/eslint-plugin-eui`: `v2.4.0` ⏩ `v2.5.0`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

---

## Changes

Related to elastic/eui#9100

- Updated snapshot f90ae29
- Added missing `aria-label` for `EuiBetaBadge`
  - [Reporting] 6d10edd
  - [ML] ce58009
- Added new translation key, ran `node scripts/i18n_check` — is there
anything else that should be done in this regard?

## Package updates

### `@elastic/eui`
[`v107.0.1`](https://github.com/elastic/eui/releases/v107.0.1)

**Bug fixes**

- Fixed `prismjs` theme in `EuiCodeBlock` to improve highlighting for
the `yaml` language ([#9089](elastic/eui#9089))
- Fixed a visual bug on `EuiTable` where the border for rows in dark
mode wasn't applied correctly
([#9115](elastic/eui#9115))

**Dependency updates**

- Updated `@elastic/prismjs-esql` to v1.1.2
([#9102](elastic/eui#9102))

**Accessibility**

- Fixed incorrect role attribute on `EuiIcon` and `EuiBetaBadge`
([#9100](elastic/eui#9100))
- Make `EuiBasicTable` respect user's reduced motion setting by not
animating when in loading state.
([#9095](elastic/eui#9095))

### `@elastic/eslint-plugin-eui`
[`v2.5.0`](https://github.com/elastic/eui/blob/main/packages/eslint-plugin/changelogs/CHANGELOG_2025.md#v250)

- Added new `accessible-interactive-element` rule.
([#9093](elastic/eui#9093))
- Added new `tooltip-focusable-anchor` rule.
([#9051](elastic/eui#9051))
- Excluded `EuiButtonEmpty` from the `no-unnamed-interactive-element`
rule. ([#9046](elastic/eui#9046))

**Bug fixes**

- Fixed `no-css-color` rule to allow CSS keywords like `currentcolor`,
`transparent`, and `inherit`
([#9092](elastic/eui#9092))

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backported bug Fixes for quality problems that affect the customer experience review v5.1.1 v6.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants