Skip to content

[5.x] Fix favicon links to use paths instead of embedded data. (#8961)#9092

Merged
cjcenizal merged 1 commit intoelastic:5.xfrom
cjcenizal:backport/8961/5.x
Nov 16, 2016
Merged

[5.x] Fix favicon links to use paths instead of embedded data. (#8961)#9092
cjcenizal merged 1 commit intoelastic:5.xfrom
cjcenizal:backport/8961/5.x

Conversation

@cjcenizal
Copy link
Copy Markdown
Contributor

Backports #8961

* Move favicon files to ui/public/assets/favicons dir.
* Serve favicons statically from ui directory, using exposeStaticDir.
@cjcenizal cjcenizal merged commit 3396233 into elastic:5.x Nov 16, 2016
@cjcenizal cjcenizal deleted the backport/8961/5.x branch November 16, 2016 00:00
airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017
… (elastic#9092)

* Move favicon files to ui/public/assets/favicons dir.
* Serve favicons statically from ui directory, using exposeStaticDir.

Former-commit-id: 3396233
acstll added a commit that referenced this pull request Oct 23, 2025
- `@elastic/eui`: `v107.0.0` ⏩ `v107.0.1`
- `@elastic/eslint-plugin-eui`: `v2.4.0` ⏩ `v2.5.0`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

---

## Changes

Related to elastic/eui#9100

- Updated snapshot f90ae29
- Added missing `aria-label` for `EuiBetaBadge`
  - [Reporting] 6d10edd
  - [ML] ce58009
- Added new translation key, ran `node scripts/i18n_check` — is there
anything else that should be done in this regard?

## Package updates

### `@elastic/eui`
[`v107.0.1`](https://github.com/elastic/eui/releases/v107.0.1)

**Bug fixes**

- Fixed `prismjs` theme in `EuiCodeBlock` to improve highlighting for
the `yaml` language ([#9089](elastic/eui#9089))
- Fixed a visual bug on `EuiTable` where the border for rows in dark
mode wasn't applied correctly
([#9115](elastic/eui#9115))

**Dependency updates**

- Updated `@elastic/prismjs-esql` to v1.1.2
([#9102](elastic/eui#9102))

**Accessibility**

- Fixed incorrect role attribute on `EuiIcon` and `EuiBetaBadge`
([#9100](elastic/eui#9100))
- Make `EuiBasicTable` respect user's reduced motion setting by not
animating when in loading state.
([#9095](elastic/eui#9095))

### `@elastic/eslint-plugin-eui`
[`v2.5.0`](https://github.com/elastic/eui/blob/main/packages/eslint-plugin/changelogs/CHANGELOG_2025.md#v250)

- Added new `accessible-interactive-element` rule.
([#9093](elastic/eui#9093))
- Added new `tooltip-focusable-anchor` rule.
([#9051](elastic/eui#9051))
- Excluded `EuiButtonEmpty` from the `no-unnamed-interactive-element`
rule. ([#9046](elastic/eui#9046))

**Bug fixes**

- Fixed `no-css-color` rule to allow CSS keywords like `currentcolor`,
`transparent`, and `inherit`
([#9092](elastic/eui#9092))

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant