Load blob.js along with filesaver.js to fix Export Schema option in Safari 7#901
Merged
rashidkpc merged 1 commit intoelastic:masterfrom Feb 11, 2014
Merged
Conversation
Contributor
|
Blob.js is MIT licensed, so no need to contact him. I'll review this and get it merged, thanks! |
edmarmoretti
pushed a commit
to edmarmoretti/kibana-pt-br
that referenced
this pull request
Sep 7, 2025
edmarmoretti
pushed a commit
to edmarmoretti/kibana-pt-br
that referenced
this pull request
Sep 7, 2025
# [24.1.0](elastic/elastic-charts@v24.0.0...v24.1.0) (2020-11-24) ### Bug Fixes * **area_charts:** correctly represent baseline with negative data points ([elastic#896](elastic/elastic-charts#896)) ([d1243f1](elastic/elastic-charts@d1243f1)) * **legend:** legend sizes with ordinal data ([elastic#867](elastic/elastic-charts#867)) ([7559e0d](elastic/elastic-charts@7559e0d)), closes [elastic#811](elastic/elastic-charts#811) * render orphan data points on lines and areas ([elastic#900](elastic/elastic-charts#900)) ([0be282b](elastic/elastic-charts@0be282b)), closes [elastic#783](elastic/elastic-charts#783) * specs swaps correctly reflected in state ([elastic#901](elastic/elastic-charts#901)) ([7fba882](elastic/elastic-charts@7fba882)) ### Features * **legend:** allow legend text to be copyable ([elastic#877](elastic/elastic-charts#877)) ([9cd3459](elastic/elastic-charts@9cd3459)), closes [elastic#710](elastic/elastic-charts#710) * allow clearing series colors from memory ([elastic#899](elastic/elastic-charts#899)) ([ab1af38](elastic/elastic-charts@ab1af38)) * merge series domain with the domain of another group ([elastic#912](elastic/elastic-charts#912)) ([325b013](elastic/elastic-charts@325b013)) * small multiples for XY charts (alpha) ([elastic#793](elastic/elastic-charts#793)) ([d288208](elastic/elastic-charts@d288208)), closes [elastic#500](elastic/elastic-charts#500) [elastic#500](elastic/elastic-charts#500)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Apologies for the previous pull which ignored the contributing...
CLA is signed. Please be aware, however, that blob.js is not my work. It is found here:
https://github.com/eligrey/Blob.js/
It is the same author of the current filesaver.js Kibana is using. The specific file I have used is the one from his demo site here:
http://eligrey.com/demos/FileSaver.js/
Reason for using the revision from demo site is that it is known to work. I know the FileSaver.js current master has issues (does not work at all in Safari 7 for me) but the demo site still works great in Safari 7, and in fact uses the same FileSaver.js version Kibana is using as far as I can tell. So I took the Blob.js from there.
Will I need to get in touch with eligrey for you so he can confirm this contribution? All I've done is tie the parts together. He maintained all of the blob.js itself.
Thanks!
Jason