fix: render orphan data points on lines and areas#900
Merged
markov00 merged 3 commits intoelastic:masterfrom Nov 12, 2020
Merged
fix: render orphan data points on lines and areas#900markov00 merged 3 commits intoelastic:masterfrom
markov00 merged 3 commits intoelastic:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #900 +/- ##
==========================================
+ Coverage 69.65% 69.91% +0.26%
==========================================
Files 340 356 +16
Lines 10950 10611 -339
Branches 2276 2147 -129
==========================================
- Hits 7627 7419 -208
+ Misses 3309 3110 -199
- Partials 14 82 +68
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
monfera
reviewed
Nov 11, 2020
Contributor
monfera
left a comment
There was a problem hiding this comment.
For aesthetic reasons and to reinforce the meaning of the marker circles, as well as emphasize the section starts and ends, maybe the section starts/ends could also have the marker.
nickofthyme
approved these changes
Nov 11, 2020
Collaborator
nickofthyme
left a comment
There was a problem hiding this comment.
LGTM, just a few minor suggestions. 👍
monfera
approved these changes
Nov 12, 2020
Contributor
monfera
left a comment
There was a problem hiding this comment.
LGTM, achieves the objective, and the section start/end markers are beyond the scope of this PR
nickofthyme
approved these changes
Nov 12, 2020
markov00
pushed a commit
that referenced
this pull request
Nov 24, 2020
# [24.1.0](v24.0.0...v24.1.0) (2020-11-24) ### Bug Fixes * **area_charts:** correctly represent baseline with negative data points ([#896](#896)) ([d1243f1](d1243f1)) * **legend:** legend sizes with ordinal data ([#867](#867)) ([7559e0d](7559e0d)), closes [#811](#811) * render orphan data points on lines and areas ([#900](#900)) ([0be282b](0be282b)), closes [#783](#783) * specs swaps correctly reflected in state ([#901](#901)) ([7fba882](7fba882)) ### Features * **legend:** allow legend text to be copyable ([#877](#877)) ([9cd3459](9cd3459)), closes [#710](#710) * allow clearing series colors from memory ([#899](#899)) ([ab1af38](ab1af38)) * merge series domain with the domain of another group ([#912](#912)) ([325b013](325b013)) * small multiples for XY charts (alpha) ([#793](#793)) ([d288208](d288208)), closes [#500](#500) [#500](#500)
Collaborator
Author
|
🎉 This PR is included in version 24.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# [24.1.0](elastic/elastic-charts@v24.0.0...v24.1.0) (2020-11-24) ### Bug Fixes * **area_charts:** correctly represent baseline with negative data points ([opensearch-project#896](elastic/elastic-charts#896)) ([b622fda](elastic/elastic-charts@b622fda)) * **legend:** legend sizes with ordinal data ([opensearch-project#867](elastic/elastic-charts#867)) ([74bcbad](elastic/elastic-charts@74bcbad)), closes [opensearch-project#811](elastic/elastic-charts#811) * render orphan data points on lines and areas ([opensearch-project#900](elastic/elastic-charts#900)) ([3e2c739](elastic/elastic-charts@3e2c739)), closes [opensearch-project#783](elastic/elastic-charts#783) * specs swaps correctly reflected in state ([opensearch-project#901](elastic/elastic-charts#901)) ([a94347f](elastic/elastic-charts@a94347f)) ### Features * **legend:** allow legend text to be copyable ([opensearch-project#877](elastic/elastic-charts#877)) ([21a96d3](elastic/elastic-charts@21a96d3)), closes [opensearch-project#710](elastic/elastic-charts#710) * allow clearing series colors from memory ([opensearch-project#899](elastic/elastic-charts#899)) ([e97f4ab](elastic/elastic-charts@e97f4ab)) * merge series domain with the domain of another group ([opensearch-project#912](elastic/elastic-charts#912)) ([716ad5a](elastic/elastic-charts@716ad5a)) * small multiples for XY charts (alpha) ([opensearch-project#793](elastic/elastic-charts#793)) ([3b88e1c](elastic/elastic-charts@3b88e1c)), closes [opensearch-project#500](elastic/elastic-charts#500) [opensearch-project#500](elastic/elastic-charts#500)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the ability to render orhpan data points displayed on a line or area chart.
An orphan data point is a datapoint that doesn't have a next or a previous data point to connect to.
The possible cases are:
If the series style is configured to show the point, it will not change the current rendering behaviour if, instead, the series style hides the point (
point:{visible: false}) on the rendering phase we filter and render only the ophan data points.fix #783
close #63
Checklist