[Lens] Add more chart editor tests based on the debug state by dej611 · Pull Request #86750 · elastic/kibana

dej611 · 2020-12-22T11:42:37Z

Summary

This PR is a rebased version of #84502 with more testing for chart XY axis.

Add multi-axis test
Add value labels test
Add axis positioning + gridlines test
Skipped partition charts tests for now ( elastic issue: Pie chart vislib replacement functional tests elastic-charts#917 )

Checklist

Unit or functional tests were updated or added to match the most common scenarios

…ata-test-2

elasticmachine · 2020-12-23T12:13:04Z

Pinging @elastic/kibana-app (Team:KibanaApp)

flash1293

Looks pretty good to me, just have one question about waiting for the chart to load

flash1293 · 2020-12-23T14:52:55Z

x-pack/test/functional/apps/lens/smokescreen.ts

+
+      await PageObjects.lens.closeDimensionEditor();
+
+      await retry.tryForTime(3000, async () => {


can we replace this with a await PageObjects.header.waitUntilLoadingHasFinished() along with the other occurences below? That's also what's used in x-pack/test/functional/apps/lens/chart_data.ts

wylieconlon · 2020-12-23T18:12:48Z

x-pack/test/functional/apps/lens/chart_data.ts

+        dimension: 'lnsXY_yDimensionPanel > lns-empty-dimension',
+        operation: 'avg',
+        field: 'bytes',
+      });


Could you load one of the existing pre-saved visualizations that are used by the other charts? Does it need to be the Terms agg?

wylieconlon · 2020-12-23T18:13:39Z

x-pack/test/functional/apps/lens/chart_data.ts

+      expect(
+        state.bars![0].bars.map((bar) => ({
+          x: bar.x,
+          y: Math.round(bar.y * 100) / 100,


Could you comment on why this rounding is needed? Or maybe the expect library has a number precision parameter?

it's because the data table rounds numbers to two decimal points, but the xy chart does not

wylieconlon · 2020-12-23T18:14:19Z

x-pack/test/functional/apps/lens/chart_data.ts

+      assertMatchesExpectedData(data!);
+    });
+
+    it.skip('should render pie chart', async () => {


Please comment on the skipped tests

dej611 · 2020-12-28T13:51:40Z

@elasticmachine merge upstream

…a into test/lens/chart-data-test-2

kibanamachine · 2020-12-28T16:21:56Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 110791b

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`lens`	1.0MB	1.0MB	+566.0B

Distributable file count

id	before	after	diff
`default`	47267	48027	+760

History

💔 Build #96303 failed afa3904
💚 Build #96134 succeeded ea276aa
💚 Build #95949 succeeded 011d1cb
💔 Build #95934 failed a1ff774

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

wylieconlon

LGTM

* master: (108 commits) [DOCS] Refreshes Data Visualizer screenshot (elastic#87017) [Security Solution] Change 'anti-virus' text to 'antivirus' (elastic#87001) [securitySolution/cypress] temporarily limit to PRs [AppServices/Examples] Add the example for Reporting integration (elastic#82091) [Build Chromium] Improve git checkout (elastic#83225) Deprecate `services.callCluster` in alerts and actions executors (elastic#86474) [Security Solution] Use system node version for Cypress and increase exec command timeout (elastic#86985) [Lens] Add more chart editor tests based on the debug state (elastic#86750) [Lens] Integrate searchSessionId into Lens app (elastic#86297) skip "pagination updates results and page number" elastic#86975 skip "Custom detection rules" elastic#83772 [logging/json] use merge from kbn/std (elastic#86330) skip network and timeline inspection. elastic#85677, elastic#85678 skip "adds correctly a filter to the global search bar" elastic#86552 [ftr/flags] improve help text (elastic#86971) skip "Fields Browser rendering. elastic#60209 skip "Closes and opens alerts" elastic#83773 [Security Solution] Skip failing Cypress tests (elastic#86967) Removes archives (elastic#86537) [ML] Fix charts grid on the Anomaly Explorer page (elastic#86904) ...

* master: (72 commits) [DOCS] Refreshes Data Visualizer screenshot (elastic#87017) [Security Solution] Change 'anti-virus' text to 'antivirus' (elastic#87001) [securitySolution/cypress] temporarily limit to PRs [AppServices/Examples] Add the example for Reporting integration (elastic#82091) [Build Chromium] Improve git checkout (elastic#83225) Deprecate `services.callCluster` in alerts and actions executors (elastic#86474) [Security Solution] Use system node version for Cypress and increase exec command timeout (elastic#86985) [Lens] Add more chart editor tests based on the debug state (elastic#86750) [Lens] Integrate searchSessionId into Lens app (elastic#86297) skip "pagination updates results and page number" elastic#86975 skip "Custom detection rules" elastic#83772 [logging/json] use merge from kbn/std (elastic#86330) skip network and timeline inspection. elastic#85677, elastic#85678 skip "adds correctly a filter to the global search bar" elastic#86552 [ftr/flags] improve help text (elastic#86971) skip "Fields Browser rendering. elastic#60209 skip "Closes and opens alerts" elastic#83773 [Security Solution] Skip failing Cypress tests (elastic#86967) Removes archives (elastic#86537) [ML] Fix charts grid on the Anomaly Explorer page (elastic#86904) ...

…86750) Co-authored-by: Joe Reuter <johannes.reuter@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine · 2020-12-31T13:24:41Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

kibanamachine · 2021-01-01T13:34:38Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

kibanamachine · 2021-01-04T13:44:39Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

…87069)

flash1293 and others added 5 commits December 22, 2020 10:33

add cahrt data test

2197202

✅ Add multi-axis testing with the new debugState API

beec4a1

🔇 Skip tests for unsupported charts

7489291

💄 Add testing identifiers

69c5dfc

✅ Add more axis tests + value labels

a1ff774

dej611 added v8.0.0 Feature:Lens labels Dec 22, 2020

This was referenced Dec 22, 2020

[Debug state] Add debug state for partition charts elastic/elastic-charts#954

Closed

[Debug state] Add additional information of debug state for XY charts elastic/elastic-charts#955

Open

dej611 added 2 commits December 22, 2020 14:05

📷 Update snapshots with new debug option

011d1cb

Merge remote-tracking branch 'upstream/master' into test/lens/chart-d…

ea276aa

…ata-test-2

dej611 marked this pull request as ready for review December 23, 2020 11:48

dej611 requested a review from a team December 23, 2020 11:48

dej611 added release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.12.0 labels Dec 23, 2020

flash1293 reviewed Dec 23, 2020

View reviewed changes

wylieconlon reviewed Dec 23, 2020

View reviewed changes

👌 Integrated review feedback

0d5b6c4

kibanamachine and others added 3 commits December 28, 2020 08:51

Merge branch 'master' into test/lens/chart-data-test-2

afa3904

🐛 Fix duplicate const scoped

a6b13b0

Merge branch 'test/lens/chart-data-test-2' of github.com:dej611/kiban…

110791b

…a into test/lens/chart-data-test-2

wylieconlon approved these changes Dec 28, 2020

View reviewed changes

dej611 merged commit 2781bf3 into elastic:master Dec 29, 2020

dej611 deleted the test/lens/chart-data-test-2 branch December 29, 2020 13:18

dej611 mentioned this pull request Dec 30, 2020

[7.x] [Lens] Add more chart editor tests based on the debug state (#86750) #87069

Merged

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 31, 2020

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 5, 2021

flash1293 pushed a commit that referenced this pull request Jan 5, 2021

[Lens] Add more chart editor tests based on the debug state (#86750) (#…

c0ef9d5

…87069)


		await PageObjects.lens.closeDimensionEditor();

		await retry.tryForTime(3000, async () => {

Conversation

dej611 commented Dec 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

elasticmachine commented Dec 23, 2020

Uh oh!

flash1293 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

flash1293 Dec 23, 2020

Choose a reason for hiding this comment

Uh oh!

wylieconlon Dec 23, 2020

Choose a reason for hiding this comment

Uh oh!

wylieconlon Dec 23, 2020

Choose a reason for hiding this comment

Uh oh!

flash1293 Dec 23, 2020

Choose a reason for hiding this comment

Uh oh!

wylieconlon Dec 23, 2020

Choose a reason for hiding this comment

Uh oh!

dej611 commented Dec 28, 2020

Uh oh!

kibanamachine commented Dec 28, 2020

💚 Build Succeeded

Metrics [docs]

Async chunks

Distributable file count

History

Uh oh!

wylieconlon left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Dec 31, 2020

Uh oh!

kibanamachine commented Jan 1, 2021

Uh oh!

kibanamachine commented Jan 4, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dej611 commented Dec 22, 2020 •

edited

Loading

flash1293 left a comment •

edited

Loading