Closed
Conversation
- move editor config components from vislib to xy plugin - import editor values from xy to vislib - move vislib type definitions to xy plugin and reference from vislib - refactor types to be consistent with elastic-charts
- add toExpression method on visType - move vislib expression build into vislib plugin - update vis types for toExpressionAst method
- add color picker component - remove unused methods from MappedColors class - add legend toggle component - add elastic charts click transforms for filter and brush events
- add detailed tooltip option to render vislib style tooltip - add fitting functions for area and line charts - fix endzones to work with detailed tooltip - make detailed tooltip default for all old vislib types
- add extra loop with newChartUI enabled - update visChart pageObject to conform to either vislib or elastic charts - update visEditor pageObject to conform to either vislib or elastic charts - update services to account for changes from xy plugin and typescriptification - convert all visualize functional tests to typescript
- update tests to use either vislib or elastic charts - add loop for newChartUI tests
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
- refactor enableHistogramMode logic to account for different groups - refactor groupIds for seperate stacked and non-stacked bars - upgrade charts to use 24.1.0
Contributor
|
Linked elastic-chart issue for pie chart: elastic/elastic-charts#917 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built on top of #78154
This PR adds some functional tests checking the chart data using the debug hooks implemented in elastic-charts.
They are currently failing because pie debug data is missing, I will work on this on the elastic-charts side.
[skip ci]