Skip to content

[logging/json] use merge from kbn/std#86330

Merged
jbudz merged 3 commits intoelastic:masterfrom
jbudz:logging/merge
Dec 28, 2020
Merged

[logging/json] use merge from kbn/std#86330
jbudz merged 3 commits intoelastic:masterfrom
jbudz:logging/merge

Conversation

@jbudz
Copy link
Copy Markdown
Contributor

@jbudz jbudz commented Dec 17, 2020

This is a quick replacement of lodash merge with { merge} from kbn/std for the JSON log formatter.

Part of #52226

@jbudz jbudz added Team:Operations Kibana-Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Dec 17, 2020
@jbudz jbudz requested a review from a team as a code owner December 17, 2020 17:14
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@jbudz jbudz added the Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// label Dec 17, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-core (Team:Core)

@pgayvallet
Copy link
Copy Markdown
Contributor

I didn't quite follow #52226, but can you remind me what we are achieving by using @kbn/std's merge instead of lodash's?

@mshustov
Copy link
Copy Markdown
Contributor

@pgayvallet it's a followup on #71138 (comment) Even if we don't have array values now, they may be in the future.

@jbudz
Copy link
Copy Markdown
Contributor Author

jbudz commented Dec 21, 2020

@elasticmachine merge upstream

Copy link
Copy Markdown
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbudz
Copy link
Copy Markdown
Contributor Author

jbudz commented Dec 28, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Distributable file count

id before after diff
default 47267 48027 +760

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jbudz jbudz merged commit 92b2b60 into elastic:master Dec 28, 2020
@jbudz jbudz deleted the logging/merge branch December 28, 2020 21:11
jbudz added a commit that referenced this pull request Dec 28, 2020
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@jbudz
Copy link
Copy Markdown
Contributor Author

jbudz commented Dec 28, 2020

7.x: 2cff2f7

gmmorris added a commit to gmmorris/kibana that referenced this pull request Dec 30, 2020
* master: (108 commits)
  [DOCS] Refreshes Data Visualizer screenshot (elastic#87017)
  [Security Solution] Change 'anti-virus' text to 'antivirus' (elastic#87001)
  [securitySolution/cypress] temporarily limit to PRs
  [AppServices/Examples] Add the example for Reporting integration (elastic#82091)
  [Build Chromium] Improve git checkout (elastic#83225)
  Deprecate `services.callCluster` in alerts and actions executors (elastic#86474)
  [Security Solution] Use system node version for Cypress and increase exec command timeout (elastic#86985)
  [Lens] Add more chart editor tests based on the debug state (elastic#86750)
  [Lens] Integrate searchSessionId into Lens app (elastic#86297)
  skip "pagination updates results and page number" elastic#86975
  skip "Custom detection rules" elastic#83772
  [logging/json] use merge from kbn/std (elastic#86330)
  skip network and timeline inspection. elastic#85677, elastic#85678
  skip "adds correctly a filter to the global search bar" elastic#86552
  [ftr/flags] improve help text (elastic#86971)
  skip "Fields Browser rendering. elastic#60209
  skip "Closes and opens alerts" elastic#83773
  [Security Solution] Skip failing Cypress tests (elastic#86967)
  Removes archives (elastic#86537)
  [ML] Fix charts grid on the Anomaly Explorer page (elastic#86904)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Dec 30, 2020
* master: (72 commits)
  [DOCS] Refreshes Data Visualizer screenshot (elastic#87017)
  [Security Solution] Change 'anti-virus' text to 'antivirus' (elastic#87001)
  [securitySolution/cypress] temporarily limit to PRs
  [AppServices/Examples] Add the example for Reporting integration (elastic#82091)
  [Build Chromium] Improve git checkout (elastic#83225)
  Deprecate `services.callCluster` in alerts and actions executors (elastic#86474)
  [Security Solution] Use system node version for Cypress and increase exec command timeout (elastic#86985)
  [Lens] Add more chart editor tests based on the debug state (elastic#86750)
  [Lens] Integrate searchSessionId into Lens app (elastic#86297)
  skip "pagination updates results and page number" elastic#86975
  skip "Custom detection rules" elastic#83772
  [logging/json] use merge from kbn/std (elastic#86330)
  skip network and timeline inspection. elastic#85677, elastic#85678
  skip "adds correctly a filter to the global search bar" elastic#86552
  [ftr/flags] improve help text (elastic#86971)
  skip "Fields Browser rendering. elastic#60209
  skip "Closes and opens alerts" elastic#83773
  [Security Solution] Skip failing Cypress tests (elastic#86967)
  Removes archives (elastic#86537)
  [ML] Fix charts grid on the Anomaly Explorer page (elastic#86904)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backported release_note:skip Skip the PR/issue when compiling release notes Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// Team:Operations Kibana-Operations Team v7.12.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants