[Search] Disable "send to background" when auto-refresh is enabled#84106
Merged
Dosant merged 2 commits intoelastic:masterfrom Dec 2, 2020
Merged
Conversation
Contributor
|
I suggest: Send to background is not available when auto refresh is enabled. |
631b3bf to
3f73adb
Compare
Contributor
|
Pinging @elastic/kibana-app-services (Team:AppServices) |
tsullivan
approved these changes
Dec 1, 2020
Member
tsullivan
left a comment
There was a problem hiding this comment.
LGTM
Reviewed the code and locally tested the functionality from the branch
Contributor
Author
|
@elasticmachine merge upstream |
…hen-refresh-interval
Contributor
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Dosant
added a commit
to Dosant/kibana
that referenced
this pull request
Dec 2, 2020
Dosant
added a commit
that referenced
this pull request
Dec 2, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Dec 2, 2020
* master: (72 commits) Make alert status fetching more resilient (elastic#84676) [APM] Refactor hooks and context (elastic#84615) Added word break styles to the texts in the item details card. (elastic#84654) [Search] Disable "send to background" when auto-refresh is enabled (elastic#84106) Add readme for new palette service (elastic#84512) Make all providers to preserve original URL when session expires. (elastic#84229) [Lens] Show color in flyout instead of auto (elastic#84532) [Lens] Use index pattern through service instead of reading saved object (elastic#84432) Make it possible to use Kibana anonymous authentication provider with ES anonymous access. (elastic#84074) TelemetryCollectionManager: Use X-Pack strategy as an OSS overwrite (elastic#84477) migrate away from rest_total_hits_as_int (elastic#84508) [Input Control] Custom renderer (elastic#84423) Attempt to more granularly separate App Search vs Workplace Search vs shared GitHub notifications (elastic#84713) [Security Solutino][Case] Case connector alert UI (elastic#82405) [Maps] Support runtime fields in tooltips (elastic#84377) [CCR] Fix row actions in follower index and auto-follow pattern tables (elastic#84433) [Enterprise Search] Migrate shared Indexing Status component (elastic#84571) [maps] remove fields from index-pattern test artifacts (elastic#84379) Add routes for use in Sources Schema (elastic#84579) Changes UI links for drilldowns (elastic#83971) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #83640
Build on top of #83073
We agreed that (at least for now) we are going to disable sending to background in case refresh interval is enabled.
This pr adds a new disabled state, which disabled button that opens a controls popover.
I made this check on connected component level. Don't see a reason for know to move it inside the service + can't make timefilter a dependency of session service.
Checklist
Delete any items that are not applicable to this PR.
For maintainers