[Security Solution][Case] Case connector alert UI by cnasikas · Pull Request #82405 · elastic/kibana

cnasikas · 2020-11-03T09:24:04Z

Summary

The PR creates the alert UI of the case connector. The feature is still WIP and is not finalized. It is the first step towards it. For this reason, it is disabled and will be enabled in the future. Also in this PR:

Creation of an alert UI for the case connector.
Disables case connector for detection engine and creates a flag to enable it if need it.
Move useInsertTimeline to cases and improve it.
Move connectors configuration to cases.
Break case creation page into smaller components.
Create case creation form component.
Create case creation modal. Create useCreateCaseModal hook.

Depends on #80870, #82715

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

x-pack/plugins/security_solution/public/cases/components/connectors/case/existing_case.tsx

x-pack/plugins/security_solution/public/cases/components/add_comment/index.test.tsx

x-pack/plugins/security_solution/public/cases/components/connectors/case/existing_case.tsx

x-pack/plugins/security_solution/public/cases/components/connectors/case/fields.tsx

This reverts commit 5e0db78.

XavierM

x-pack/plugins/security_solution/public/cases/components/create/index.tsx Line 27 and x-pack/plugins/security_solution/public/cases/components/use_create_case_modal/create_case_modal.tsx Line 36

The component Submit button is identical, can we create a common one?

XavierM

I trust you that you will fix my nit before merging 😍.

I reviewed the code and I do appreciate that you clean up the code nicely around the creation of the case. I also like the cleanup around the tags and adopting the improvement around the kbn-form.

Thanks a lot, Future Engineer will appreciate you on this one!!!!

cnasikas · 2020-12-01T19:31:40Z

@elasticmachine merge upstream

Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/security_solution/public/cases/components/create/index.test.tsx

kibanamachine · 2020-12-01T23:23:01Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: f4f180f

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`securitySolution`	2080	2094	+14

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	8.0MB	8.0MB	+6.9KB

Distributable file count

id	before	after	diff
`default`	43183	43195	+12

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`securitySolution`	173.1KB	207.1KB	+34.0KB

Unknown metric groups

async chunk count

id	before	after	diff
`securitySolution`	11	15	+4

History

💚 Build #91197 succeeded f4f180f
💚 Build #91143 succeeded 8208ae8
💔 Build #90967 failed 0a9b9e0d72a2504f9c335176d8efe881dda5b6e8
💔 Build #90848 failed 7e62d78269aa69620d83040a6aec69c7f2c0ed18
💚 Build #90797 succeeded b49be2d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

) Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/security_solution/public/cases/components/create/index.test.tsx

* master: [Lens] Show color in flyout instead of auto (elastic#84532) [Lens] Use index pattern through service instead of reading saved object (elastic#84432) Make it possible to use Kibana anonymous authentication provider with ES anonymous access. (elastic#84074) TelemetryCollectionManager: Use X-Pack strategy as an OSS overwrite (elastic#84477) migrate away from rest_total_hits_as_int (elastic#84508) [Input Control] Custom renderer (elastic#84423) Attempt to more granularly separate App Search vs Workplace Search vs shared GitHub notifications (elastic#84713) [Security Solutino][Case] Case connector alert UI (elastic#82405) [Maps] Support runtime fields in tooltips (elastic#84377) [CCR] Fix row actions in follower index and auto-follow pattern tables (elastic#84433) [Enterprise Search] Migrate shared Indexing Status component (elastic#84571) [maps] remove fields from index-pattern test artifacts (elastic#84379) Add routes for use in Sources Schema (elastic#84579) Changes UI links for drilldowns (elastic#83971) endpoint telemetry cloned endpoint tests (elastic#81498) [Fleet] Handler api key creation errors when Fleet Admin is invalid (elastic#84576)

* master: (72 commits) Make alert status fetching more resilient (elastic#84676) [APM] Refactor hooks and context (elastic#84615) Added word break styles to the texts in the item details card. (elastic#84654) [Search] Disable "send to background" when auto-refresh is enabled (elastic#84106) Add readme for new palette service (elastic#84512) Make all providers to preserve original URL when session expires. (elastic#84229) [Lens] Show color in flyout instead of auto (elastic#84532) [Lens] Use index pattern through service instead of reading saved object (elastic#84432) Make it possible to use Kibana anonymous authentication provider with ES anonymous access. (elastic#84074) TelemetryCollectionManager: Use X-Pack strategy as an OSS overwrite (elastic#84477) migrate away from rest_total_hits_as_int (elastic#84508) [Input Control] Custom renderer (elastic#84423) Attempt to more granularly separate App Search vs Workplace Search vs shared GitHub notifications (elastic#84713) [Security Solutino][Case] Case connector alert UI (elastic#82405) [Maps] Support runtime fields in tooltips (elastic#84377) [CCR] Fix row actions in follower index and auto-follow pattern tables (elastic#84433) [Enterprise Search] Migrate shared Indexing Status component (elastic#84571) [maps] remove fields from index-pattern test artifacts (elastic#84379) Add routes for use in Sources Schema (elastic#84579) Changes UI links for drilldowns (elastic#83971) ...

cnasikas added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Nov 3, 2020

cnasikas self-assigned this Nov 3, 2020

cnasikas changed the title ~~[Security Solutino][Case] Case connector alert UI~~ [Security Solutino][Case][skip-ci] Case connector alert UI Nov 3, 2020

cnasikas force-pushed the case_connector_alert branch 2 times, most recently from 59f2c72 to 42c8d31 Compare November 3, 2020 17:42

cnasikas mentioned this pull request Nov 4, 2020

[Security Solution][Case] Case action type #80870

Merged

4 tasks

cnasikas force-pushed the case_connector_alert branch 2 times, most recently from e6cf55a to ce13d5c Compare November 5, 2020 14:32

cnasikas force-pushed the case_connector_alert branch 3 times, most recently from fd2a7b5 to 8d7de4e Compare November 13, 2020 18:05

cnasikas force-pushed the case_connector_alert branch from 8d7de4e to 1dfcd44 Compare November 20, 2020 14:37

cnasikas changed the title ~~[Security Solutino][Case][skip-ci] Case connector alert UI~~ [Security Solutino][Case] Case connector alert UI Nov 20, 2020

cnasikas marked this pull request as ready for review November 20, 2020 15:52

cnasikas requested review from a team as code owners November 20, 2020 15:52

cnasikas force-pushed the case_connector_alert branch 7 times, most recently from dc8e5dc to 337295e Compare November 23, 2020 10:15

cnasikas mentioned this pull request Nov 23, 2020

[Security Solution][Case] Manual attach alert to a case #82996

Merged

8 tasks

XavierM reviewed Nov 24, 2020

View reviewed changes

x-pack/plugins/security_solution/public/cases/components/connectors/case/existing_case.tsx Outdated Show resolved Hide resolved

Fix test

2baee8c

cnasikas force-pushed the case_connector_alert branch from 8e867e2 to 0b35fd2 Compare November 30, 2020 14:00

XavierM reviewed Nov 30, 2020

View reviewed changes

x-pack/plugins/security_solution/public/cases/components/add_comment/index.test.tsx Outdated Show resolved Hide resolved

XavierM reviewed Nov 30, 2020

View reviewed changes

x-pack/plugins/security_solution/public/cases/components/connectors/case/existing_case.tsx Outdated Show resolved Hide resolved

XavierM reviewed Nov 30, 2020

View reviewed changes

x-pack/plugins/security_solution/public/cases/components/connectors/case/fields.tsx Outdated Show resolved Hide resolved

Add and improve tests

1d3198f

cnasikas force-pushed the case_connector_alert branch from 0b35fd2 to 1d3198f Compare November 30, 2020 16:10

cnasikas added 3 commits November 30, 2020 18:48

Improve tags

ff53a8a

Revert "Rename action from insertTimeline to attachTimeline"

b49be2d

This reverts commit 5e0db78.

Better path

9f00381

XavierM reviewed Nov 30, 2020

View reviewed changes

XavierM approved these changes Nov 30, 2020

View reviewed changes

cnasikas force-pushed the case_connector_alert branch 3 times, most recently from 57ddfd3 to 0a9b9e0 Compare December 1, 2020 09:15

Improvements

8208ae8

cnasikas force-pushed the case_connector_alert branch from 0a9b9e0 to 8208ae8 Compare December 1, 2020 17:44

Merge branch 'master' into case_connector_alert

f4f180f

cnasikas merged commit b9a64ba into elastic:master Dec 1, 2020

cnasikas deleted the case_connector_alert branch December 1, 2020 21:39

cnasikas mentioned this pull request Dec 1, 2020

[7.x] [Security Solution][Case] Case connector alert UI (#82405) #84712

Merged

cnasikas changed the title ~~[Security Solutino][Case] Case connector alert UI~~ [Security Solution][Case] Case connector alert UI Dec 1, 2020

cnasikas mentioned this pull request Jan 5, 2021

[Security Solution][Case] Improve quote handling #74144

Closed

e40pud mentioned this pull request Jul 14, 2023

Failing ES Promotion: x-pack/plugins/security_solution/public/cases/components/create.Create case Step 2 - Connector Fields should change from none to Jira connector fields #84145

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution][Case] Case connector alert UI#82405

[Security Solution][Case] Case connector alert UI#82405
cnasikas merged 26 commits intoelastic:masterfrom
cnasikas:case_connector_alert

cnasikas commented Nov 3, 2020 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

XavierM left a comment •

edited

Loading

Uh oh!

XavierM left a comment •

edited

Loading

Uh oh!

cnasikas commented Dec 1, 2020

Uh oh!

kibanamachine commented Dec 1, 2020

async chunk count

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

cnasikas commented Nov 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

XavierM left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

XavierM left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cnasikas commented Dec 1, 2020

Uh oh!

kibanamachine commented Dec 1, 2020

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Distributable file count

Page load bundle

async chunk count

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cnasikas commented Nov 3, 2020 •

edited

Loading

XavierM left a comment •

edited

Loading

XavierM left a comment •

edited

Loading