Skip to content

Revert "[Search] Search batching using bfetch (#83418)"#84037

Merged
mistic merged 1 commit intoelastic:masterfrom
mistic:revert-pr-83418
Nov 23, 2020
Merged

Revert "[Search] Search batching using bfetch (#83418)"#84037
mistic merged 1 commit intoelastic:masterfrom
mistic:revert-pr-83418

Conversation

@mistic
Copy link
Copy Markdown
Contributor

@mistic mistic commented Nov 22, 2020

That PR reverts #83418 as after merging it our CI started to failing. I'm doing that to get our CI to a green state again so we can have it unblocked for tomorrow morning.

After talking with @patrykkopycinski we think that is the quicker and safer action for now.

@mistic mistic added chore Team:Operations Kibana-Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Nov 22, 2020
@mistic mistic requested a review from a team as a code owner November 22, 2020 23:07
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@botelastic botelastic bot added Feature:Embedding Embedding content via iFrame Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) labels Nov 22, 2020
@mistic mistic requested a review from lizozom November 22, 2020 23:08
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
bfetch 21 20 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
bfetch 19.9KB 18.6KB -1.2KB
data 973.6KB 974.0KB +417.0B
dataEnhanced 36.3KB 36.3KB -28.0B
total -862.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic merged commit d7cdcf6 into elastic:master Nov 23, 2020
@mistic mistic added the v7.11.0 label Nov 23, 2020
mistic added a commit to mistic/kibana that referenced this pull request Nov 23, 2020
@mistic
Copy link
Copy Markdown
Contributor Author

mistic commented Nov 23, 2020

7.x: b80f2a3

mistic added a commit that referenced this pull request Nov 23, 2020
gmmorris added a commit to rudolf/kibana that referenced this pull request Nov 23, 2020
* master: (67 commits)
  [Observability] Load hasData call asynchronously (elastic#80644)
  Implement AnonymousAuthenticationProvider. (elastic#79985)
  Deprecate `visualization:colorMapping` advanced setting (elastic#83372)
  [TSVB] [Rollup] Table tab not working with rollup indexes (elastic#83635)
  Revert "[Search] Search batching using bfetch (elastic#83418)" (elastic#84037)
  skip flaky suite (elastic#83772)
  skip flaky suite (elastic#69849)
  create kbn-legacy-logging package (elastic#77678)
  [Search] Search batching using bfetch (elastic#83418)
  [Security Solution] Refactor Timeline flyout to take a full page (elastic#82033)
  Drop use of console-stamp (elastic#83922)
  skip flaky suite (elastic#84011 , elastic#84012)
  Fixed usage of `isReady` for usage collection of alerts and actions (elastic#83760)
  [maps] support URL drilldowns (elastic#83732)
  Revert "Added default dedupKey value as an {{alertInstanceId}} to provide grouping functionality for PagerDuty incidents. (elastic#83226)"
  [code coverage] Update jest config to collect more data (elastic#83804)
  Added default dedupKey value as an {{alertInstanceId}} to provide grouping functionality for PagerDuty incidents. (elastic#83226)
  [Security Solution] Give notice when endpoint policy is out of date (elastic#83469)
  [Security Solution] Sync url state on any changes to query string (elastic#83314)
  [CI] Initial TeamCity implementation (elastic#81043)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Feature:Embedding Embedding content via iFrame Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.11.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants