Fixed usage of isReady for usage collection of alerts and actions#83760
Merged
YulNaumenko merged 6 commits intoelastic:masterfrom Nov 21, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
gmmorris
suggested changes
Nov 19, 2020
Contributor
gmmorris
left a comment
There was a problem hiding this comment.
I left a few notes about RX usage and inlining the isReady to avoid an intermediary variable.
I'll try and validate my theory about the task potentially stalling, but in either case, we don't want the task to wait on a fresh config every time, so that should be addressed.
Contributor
💛 Build succeeded, but was flaky
Test FailuresChrome X-Pack UI Functional Tests.x-pack/test/functional/apps/dashboard/drilldowns/dashboard_to_url_drilldown·ts.dashboard drilldowns Dashboard to URL drilldown should create dashboard to URL drilldown and use it to navigate to discoverStandard OutStack TraceMetrics [docs]
History
To update your PR or re-run it, just comment with: |
YulNaumenko
added a commit
to YulNaumenko/kibana
that referenced
this pull request
Nov 21, 2020
…lastic#83760) * Fixed usage of `isReady` for usage collection of alerts and actions * fixed index * fixed due to comments * fixed type check * fixed due to comments
gmmorris
added a commit
to rudolf/kibana
that referenced
this pull request
Nov 23, 2020
* master: (67 commits) [Observability] Load hasData call asynchronously (elastic#80644) Implement AnonymousAuthenticationProvider. (elastic#79985) Deprecate `visualization:colorMapping` advanced setting (elastic#83372) [TSVB] [Rollup] Table tab not working with rollup indexes (elastic#83635) Revert "[Search] Search batching using bfetch (elastic#83418)" (elastic#84037) skip flaky suite (elastic#83772) skip flaky suite (elastic#69849) create kbn-legacy-logging package (elastic#77678) [Search] Search batching using bfetch (elastic#83418) [Security Solution] Refactor Timeline flyout to take a full page (elastic#82033) Drop use of console-stamp (elastic#83922) skip flaky suite (elastic#84011 , elastic#84012) Fixed usage of `isReady` for usage collection of alerts and actions (elastic#83760) [maps] support URL drilldowns (elastic#83732) Revert "Added default dedupKey value as an {{alertInstanceId}} to provide grouping functionality for PagerDuty incidents. (elastic#83226)" [code coverage] Update jest config to collect more data (elastic#83804) Added default dedupKey value as an {{alertInstanceId}} to provide grouping functionality for PagerDuty incidents. (elastic#83226) [Security Solution] Give notice when endpoint policy is out of date (elastic#83469) [Security Solution] Sync url state on any changes to query string (elastic#83314) [CI] Initial TeamCity implementation (elastic#81043) ...
pmuellr
reviewed
Nov 23, 2020
Contributor
pmuellr
left a comment
There was a problem hiding this comment.
Left a question whether the this.kibanaIndexConfig.subscribe() will end up calling the subscriber > 1 times.
| 'actions', | ||
| this.createRouteHandlerContext(core, await this.kibanaIndex) | ||
| ); | ||
| this.kibanaIndexConfig.subscribe((config) => { |
Contributor
There was a problem hiding this comment.
I noticed that for other uses, we actually only deal with the "first" update of kibanaIndexConfig via kibanaIndexConfig.pipe(first()).toPromise(), but not here.
So it seems like if this.kibanaIndexConfig emits > 1 times per Kibana startup, we'd try to register the routes > 1 times. The same pattern is used in alerts.
Thinking perhaps we should just set kibanaIndexConfig to the following, for consistency, then we can remove the other pipe(first()) usages. Or perhaps I'm missing something.
initContext.config.legacy.globalConfig$.pipe(first())
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current PR includes the changes which make the requirement for actions and alerts collectors to set isReady as true only when the TaskManager plugin will be ready.
Changed alerts plugin setup method to be a synchronous.
Resolve #82947