Added default dedupKey value as an {{alertInstanceId}} to provide grouping functionality for PagerDuty incidents.#83226
Merged
YulNaumenko merged 10 commits intoelastic:masterfrom Nov 20, 2020
Conversation
…uping functionality for PagerDuty incidents. Set default savedObjectId as {{alertInstanceId}} for ServiceNow, Resilient and Jira
Contributor
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
mikecote
reviewed
Nov 17, 2020
...actions_ui/public/application/components/builtin_action_types/pagerduty/pagerduty_params.tsx
Outdated
Show resolved
Hide resolved
mikecote
reviewed
Nov 17, 2020
Contributor
There was a problem hiding this comment.
I took a look at the PR / approach today and I think it would be better to move this logic outside the connector code as it now couples them to the alert. I wonder if we can do something from the alert components to get a list of default connector values which then gets passed to the connector components (like a switch case for defaults).
Testing the connector currently shows a dedup key that is alert specific:
gmmorris
reviewed
Nov 19, 2020
Contributor
gmmorris
left a comment
There was a problem hiding this comment.
LGTM, just a couple of notes :)
.../triggers_actions_ui/public/application/components/builtin_action_types/jira/jira_params.tsx
Outdated
Show resolved
Hide resolved
...actions_ui/public/application/components/builtin_action_types/pagerduty/pagerduty_params.tsx
Outdated
Show resolved
Hide resolved
gmmorris
approved these changes
Nov 19, 2020
mikecote
approved these changes
Nov 20, 2020
Contributor
mikecote
left a comment
There was a problem hiding this comment.
Changes LGTM, its nice to see it auto select "Resolve" for the PagerDuty event action!
x-pack/plugins/triggers_actions_ui/public/application/lib/get_defaults_for_action_params.ts
Outdated
Show resolved
Hide resolved
Contributor
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
YulNaumenko
added a commit
to YulNaumenko/kibana
that referenced
this pull request
Nov 20, 2020
…uping functionality for PagerDuty incidents. (elastic#83226) * Added default dedupKey value as an {{alertInstanceId}} to provide grouping functionality for PagerDuty incidents. Set default savedObjectId as {{alertInstanceId}} for ServiceNow, Resilient and Jira * fixed comment * fixed due to comments * fixed doc * fixed due to comments
Contributor
|
@YulNaumenko I'm sorry, I had to revert this PR... It ended up having a conflict with another PR that was merged earlier. Can you create another PR that's up-to-date with master and get that resolved? See here: https://kibana-ci.elastic.co/job/elastic+kibana+master/9808/execution/node/353/log/ It looks like your 7.x backport is currently failing with the same issue |
YulNaumenko
added a commit
that referenced
this pull request
Nov 21, 2020
…de grouping functionality for PagerDuty incidents. (#83226) (#83985) * Added default dedupKey value as an {{alertInstanceId}} to provide grouping functionality for PagerDuty incidents. (#83226) * Added default dedupKey value as an {{alertInstanceId}} to provide grouping functionality for PagerDuty incidents. Set default savedObjectId as {{alertInstanceId}} for ServiceNow, Resilient and Jira * fixed comment * fixed due to comments * fixed doc * fixed due to comments * fixed type checks
gmmorris
added a commit
to rudolf/kibana
that referenced
this pull request
Nov 23, 2020
* master: (67 commits) [Observability] Load hasData call asynchronously (elastic#80644) Implement AnonymousAuthenticationProvider. (elastic#79985) Deprecate `visualization:colorMapping` advanced setting (elastic#83372) [TSVB] [Rollup] Table tab not working with rollup indexes (elastic#83635) Revert "[Search] Search batching using bfetch (elastic#83418)" (elastic#84037) skip flaky suite (elastic#83772) skip flaky suite (elastic#69849) create kbn-legacy-logging package (elastic#77678) [Search] Search batching using bfetch (elastic#83418) [Security Solution] Refactor Timeline flyout to take a full page (elastic#82033) Drop use of console-stamp (elastic#83922) skip flaky suite (elastic#84011 , elastic#84012) Fixed usage of `isReady` for usage collection of alerts and actions (elastic#83760) [maps] support URL drilldowns (elastic#83732) Revert "Added default dedupKey value as an {{alertInstanceId}} to provide grouping functionality for PagerDuty incidents. (elastic#83226)" [code coverage] Update jest config to collect more data (elastic#83804) Added default dedupKey value as an {{alertInstanceId}} to provide grouping functionality for PagerDuty incidents. (elastic#83226) [Security Solution] Give notice when endpoint policy is out of date (elastic#83469) [Security Solution] Sync url state on any changes to query string (elastic#83314) [CI] Initial TeamCity implementation (elastic#81043) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added default dedupKey value as an
{{alertId}}:{{alertInstanceId}}to provide grouping functionality for PagerDuty incidents.Exposed getDefaultsForActionParams function which returns the default action params values for a selected action group
Resolve #77772