[Reporting] Move "common" types and constants into common#83198
Merged
tsullivan merged 1 commit intoelastic:masterfrom Nov 12, 2020
Merged
[Reporting] Move "common" types and constants into common#83198tsullivan merged 1 commit intoelastic:masterfrom
tsullivan merged 1 commit intoelastic:masterfrom
Conversation
b232cd2 to
d6e6b14
Compare
tsullivan
commented
Nov 11, 2020
Member
Author
There was a problem hiding this comment.
VS Code auto-import rules have definitely changed 😿
Hopefully this type of noise can be disregarded.
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
fdc135c to
7a59edb
Compare
f1a97f2 to
3456f60
Compare
a918db6 to
9e83e9a
Compare
cfe7c1e to
daba279
Compare
tsullivan
commented
Nov 11, 2020
| import { reportingPDFPNGProvider } from './share_context_menu/register_pdf_png_reporting'; | ||
|
|
||
| export interface ClientConfigType { | ||
| poll: ReportingConfigType['poll']; |
Member
Author
There was a problem hiding this comment.
This type comes from the server code, and can not easily be moved to common
Contributor
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
Page load bundle
History
To update your PR or re-run it, just comment with: |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Nov 12, 2020
…ntegration (elastic#83198) # Conflicts: # x-pack/plugins/reporting/server/export_types/printable_pdf/create_job/index.ts # x-pack/plugins/reporting/server/types.ts
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Nov 12, 2020
* master:
[Ingest Manager] Lift up registry/{stream,extract} functions (elastic#83239)
[Reporting] Move "common" types and constants to allow cross-plugin integration (elastic#83198)
[Lens] Add suffix formatter (elastic#82852)
[App Search] Version documentation links (elastic#83245)
Use saved object references for dashboard drilldowns (elastic#82602)
Btsymbala/registered av (elastic#81910)
[APM] Errors table for service overview (elastic#83065)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This code has been pulled from PR: #82091 to make 1 large PR into 2 atomic PRs.
See https://github.com/tsullivan/kibana/blob/reporting/feature-control-example/examples/reporting_example/public/components/app.tsx#L35 for an example of how an outside plugin can use the Reporting contract.
Problem addressed by this PR: Applications and plugins that require Reporting integration should be able to list the
reportingdependency, and access modules from the Reporting Service via their start/stop methods of the Kibana Platform. Unfortunately, not all the modules they would want are accessible in UI code: they're useful, but they are:reporting/index,reporting/public, orreporting/commonserver/libcodeThis PR moves a lot of the constants and types that were originally defined in "server" into "common". It also makes a few constants, and helper functions available on the "public" contract. Those are needed in a followup PR to implement an example plugin for Reporting.
List of Changes
ReportingStartandReportingSetupinterfaces for plugin contractreporting/constants.ts(ambiguous purpose) and put declarations inreporting/common/constants.tsreporting/public/index.tstoreporting/common/types.tsreporting/server/lib/layoutsandreporting/server/lib/storeintoreporting/common/types@kbn/eslint/no-restricted-pathsrelated to hacky exporting in previous codeChecklist
Delete any items that are not applicable to this PR.
For maintainers