Btsymbala/registered av by efreeti · Pull Request #81910 · elastic/kibana

efreeti · 2020-10-28T15:38:30Z

Summary

Added Antivirus registration switch in the policy form. Additionally fixed a bit layout and text styling as per discussion with Bonnie. Fixed the mobile view.

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

…l higher.

…icy.

…ness.

…l higher.

elasticmachine · 2020-10-30T20:48:34Z

Pinging @elastic/endpoint-app-team (Feature:Endpoint)

…bala/registered-av

…thin security app.

paul-tavares

LGTM 👍

@parkiino : would you take a quick look as well since you are most familiar with the policy edit forms 😬

…bala/registered-av � Conflicts: � x-pack/plugins/security_solution/public/management/pages/policy/view/policy_forms/protections/malware.tsx

parkiino · 2020-11-04T17:22:10Z

...curity_solution/public/management/pages/policy/view/components/config_form/index.stories.tsx

+storiesOf('PolicyDetails/ConfigForm', module)
+  .add('One OS', () => {
+    return (
+      <ConfigForm type="Type 1" supportedOss={['windows']}>


should we use the os enums you made here?

If you refer to os.ts file then it contains only type definitions, unfortunately literal types can not be used as keys/symbols directly. I plan to later revisit this and add some constant to keep the keys.

parkiino · 2020-11-04T17:30:52Z

x-pack/plugins/security_solution/public/management/pages/policy/store/policy_details/reducer.ts

    return newState;
  }

+  if (action.type === 'userChangedAntivirusRegistration') {


Is there a reason why you created a separate action for antivirus registration specifically? If I am reading this right, it seems like the antivirus_registration is just another key within the policy config. The action userChangedPolicyConfig should be able to do the same thing. ex) https://github.com/elastic/kibana/blob/master/x-pack/plugins/security_solution/public/management/pages/policy/view/policy_forms/protections/malware.tsx#L53

I will bring this up during next week office hours. General thought was to avoid components being too smart and knowing how to update properties in policy config and rather keep the logic out (specifically move it to redux). What are your thoughts on this?

I noticed that due to this logic living in component we clone policy twice and have some ts-ignore directives because the code violates immutability.

ooh okie, i can see the value in moving logic into redux, i guess im just wondering if its possible to make it more robust since i feel like policy details will only get bigger in the future?

…bala/registered-av

efreeti · 2020-11-11T15:47:01Z

@elasticmachine merge upstream

kibanamachine · 2020-11-11T17:34:28Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 773204f

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`securitySolution`	2068	2071	+3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	7.8MB	7.8MB	+549.0B

Distributable file count

id	before	after	diff
`default`	42778	42779	+1

History

💚 Build #86677 succeeded f1b02f3
💚 Build #85877 succeeded 41b9750
💔 Build #85836 failed 98360a8
💚 Build #85288 succeeded 15c0265
💔 Build #85250 failed 623a91b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* master: [Ingest Manager] Lift up registry/{stream,extract} functions (elastic#83239) [Reporting] Move "common" types and constants to allow cross-plugin integration (elastic#83198) [Lens] Add suffix formatter (elastic#82852) [App Search] Version documentation links (elastic#83245) Use saved object references for dashboard drilldowns (elastic#82602) Btsymbala/registered av (elastic#81910) [APM] Errors table for service overview (elastic#83065)

kibanamachine · 2020-11-16T14:54:39Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 81910 or prevent reminders by adding the backport:skip label.

* Moved out type for OperatingSystem and moved OS translations one level higher. * Changed the translation to be consistent between trusted apps and policy. * Unified translations of OS types between trusted apps and policy. * Removed unused types. * Added registered AV form section. * Changed the property structure to match the format expected by endpoint. * Fixed the visual alignment of titles in the form and added responsiveness. * Updated snapshots. * Moved out type for OperatingSystem and moved OS translations one level higher. * Added config form heading component. * Cleaned up translations. * Fixed type error with initialization. * Fixed error in trusted app creation form test. * Removed the guard for now in favour of better initialization. * Fixed the store test. * Fixing functional test data. * Added functional test config option to account for a custom header within security app. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* Moved out type for OperatingSystem and moved OS translations one level higher. * Changed the translation to be consistent between trusted apps and policy. * Unified translations of OS types between trusted apps and policy. * Removed unused types. * Added registered AV form section. * Changed the property structure to match the format expected by endpoint. * Fixed the visual alignment of titles in the form and added responsiveness. * Updated snapshots. * Moved out type for OperatingSystem and moved OS translations one level higher. * Added config form heading component. * Cleaned up translations. * Fixed type error with initialization. * Fixed error in trusted app creation form test. * Removed the guard for now in favour of better initialization. * Fixed the store test. * Fixing functional test data. * Added functional test config option to account for a custom header within security app. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

efreeti added 10 commits October 26, 2020 16:41

Moved out type for OperatingSystem and moved OS translations one leve…

12f6191

…l higher.

Changed the translation to be consistent between trusted apps and pol…

0501c1d

…icy.

Unified translations of OS types between trusted apps and policy.

56f8f44

Removed unused types.

7e216d7

Added registered AV form section.

0b4a7eb

Changed the property structure to match the format expected by endpoint.

62db297

Fixed the visual alignment of titles in the form and added responsive…

509aace

…ness.

Updated snapshots.

25d0d48

Moved out type for OperatingSystem and moved OS translations one leve…

4734757

…l higher.

Added config form heading component.

fbff194

efreeti self-assigned this Oct 30, 2020

Added config form heading component.

ecfc5b3

efreeti marked this pull request as ready for review October 30, 2020 20:48

efreeti requested review from a team as code owners October 30, 2020 20:48

efreeti added 7 commits November 2, 2020 12:46

Cleaned up translations.

7a1d007

Merge branch 'master' of https://github.com/elastic/kibana into btsym…

ee19c19

…bala/registered-av

Fixed type error with initialization.

7289449

Fixed error in trusted app creation form test.

8a07958

Removed the guard for now in favour of better initialization.

9e1fed6

Fixed the store test.

623a91b

Fixing functional test data.

df503b5

Added functional test config option to account for a custom header wi…

15c0265

…thin security app.

paul-tavares approved these changes Nov 3, 2020

View reviewed changes

Merge branch 'master' of https://github.com/elastic/kibana into btsym…

98360a8

…bala/registered-av � Conflicts: � x-pack/plugins/security_solution/public/management/pages/policy/view/policy_forms/protections/malware.tsx

kevinlog approved these changes Nov 4, 2020

View reviewed changes

parkiino reviewed Nov 4, 2020

View reviewed changes

Merge branch 'master' of https://github.com/elastic/kibana into btsym…

41b9750

…bala/registered-av

parkiino approved these changes Nov 4, 2020

View reviewed changes

Merge branch 'master' of https://github.com/elastic/kibana into btsym…

f1b02f3

…bala/registered-av

Merge branch 'master' into btsymbala/registered-av

773204f

efreeti merged commit 58ad7ec into elastic:master Nov 12, 2020

efreeti deleted the btsymbala/registered-av branch November 12, 2020 14:54

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 16, 2020

efreeti mentioned this pull request Nov 16, 2020

[7.x] Btsymbala/registered av (#81910) #83475

Merged

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 17, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Btsymbala/registered av#81910

Btsymbala/registered av#81910
efreeti merged 23 commits intoelastic:masterfrom
efreeti:btsymbala/registered-av

efreeti commented Oct 28, 2020 •

edited

Loading

Uh oh!

elasticmachine commented Oct 30, 2020

Uh oh!

paul-tavares left a comment

Uh oh!

parkiino Nov 4, 2020

Uh oh!

efreeti Nov 4, 2020

Uh oh!

parkiino Nov 4, 2020

Uh oh!

efreeti Nov 4, 2020

Uh oh!

parkiino Nov 4, 2020

Uh oh!

efreeti commented Nov 11, 2020 •

edited

Loading

Uh oh!

kibanamachine commented Nov 11, 2020

Uh oh!

kibanamachine commented Nov 16, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

efreeti commented Oct 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

elasticmachine commented Oct 30, 2020

Uh oh!

paul-tavares left a comment

Choose a reason for hiding this comment

Uh oh!

parkiino Nov 4, 2020

Choose a reason for hiding this comment

Uh oh!

efreeti Nov 4, 2020

Choose a reason for hiding this comment

Uh oh!

parkiino Nov 4, 2020

Choose a reason for hiding this comment

Uh oh!

efreeti Nov 4, 2020

Choose a reason for hiding this comment

Uh oh!

parkiino Nov 4, 2020

Choose a reason for hiding this comment

Uh oh!

efreeti commented Nov 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kibanamachine commented Nov 11, 2020

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Distributable file count

History

Uh oh!

kibanamachine commented Nov 16, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

efreeti commented Oct 28, 2020 •

edited

Loading

efreeti commented Nov 11, 2020 •

edited

Loading