[APM] Service overview: Errors table#83065
Merged
dgieselaar merged 7 commits intoelastic:masterfrom Nov 12, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/apm-ui (Team:apm) |
smith
requested changes
Nov 11, 2020
Contributor
smith
left a comment
There was a problem hiding this comment.
Code looks good.
I'm having a few issues:
- If I set the time range to 90 days I get a 503:
statusCode: 503,
response:
'{"error":{"root_cause":[],"type":"search_phase_execution_exception","reason":"","phase":"fetch","grouped":true,"failed_shards":[],"caused_by":{"type":"too_many_buckets_exception","reason":"Trying to create too many buckets. Must be less than or equal to: [65535] but was [65611]. This limit can be set by changing the [search.max_buckets] cluster level setting.","max_buckets":65535}},"status":503}',
toString: [Function],
toJSON: [Function] }
server error [13:43:06.856] Error: Internal Server Error
at HapiResponseAdapter.toInternalError (/Users/smith/Code/kibana/src/core/server/http/router/response_adapter.ts:59:19)
at Router.handle (/Users/smith/Code/kibana/src/core/server/http/router/router.ts:286:34)
at process._tickCallback (internal/process/next_tick.js:68:7)
- The number of occurrences can overflow the left side of the table. Should we leave "occ." off?
- Should the number be formatted? ("78,027" instead of "78027")
- When we have all five rows there's too much whitespace at the bottom of the chart next to it. I can fix this in a follow-up PR since I'm working on the charts.
Contributor
Author
|
@smith great feedback, thanks. I've set the last seen and occurrences column to fixed widths. I've also made some changes to the way data is fetched to prevent the |
gmmorris
approved these changes
Nov 12, 2020
Contributor
gmmorris
left a comment
There was a problem hiding this comment.
The changes to TM look like simple additions to mocks, so as long as the tests are stil lgreen LGTM 👍
smith
approved these changes
Nov 12, 2020
dgieselaar
added a commit
to dgieselaar/kibana
that referenced
this pull request
Nov 12, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Nov 12, 2020
* master:
[Ingest Manager] Lift up registry/{stream,extract} functions (elastic#83239)
[Reporting] Move "common" types and constants to allow cross-plugin integration (elastic#83198)
[Lens] Add suffix formatter (elastic#82852)
[App Search] Version documentation links (elastic#83245)
Use saved object references for dashboard drilldowns (elastic#82602)
Btsymbala/registered av (elastic#81910)
[APM] Errors table for service overview (elastic#83065)
dgieselaar
added a commit
that referenced
this pull request
Nov 12, 2020
Closed
Contributor
⏳ Build in-progress, with failures
Failed CI StepsHistory
To update your PR or re-run it, just comment with: |
Contributor
💔 Build Failed
Failed CI Steps
Test FailuresX-Pack Accessibility Tests.x-pack/test/accessibility/apps/dashboard_edit_panel·ts.Dashboard Edit Panel "before all" hook for " A11y test on dashboard edit panel menu options"Standard OutStack TraceFirefox XPack UI Functional Tests.x-pack/test/functional/apps/canvas.Canvas app "before all" hook in "Canvas app"Standard OutStack TraceFirefox XPack UI Functional Tests.x-pack/test/functional/apps/canvas.Canvas app "after all" hook in "Canvas app"Standard OutStack Traceand 9 more failures, only showing the first 3. Metrics [docs]Module Count
Async chunks
Distributable file count
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #81725.
Does not include the "First seen" column yet, as we are still figuring out whether we want to show that.