Merged
Conversation
cjcenizal
approved these changes
Nov 6, 2020
Contributor
cjcenizal
left a comment
There was a problem hiding this comment.
Changes to ES UI snapshots LGTM. Thanks for keeping us up-to-date, Greg!
Contributor
|
Pinging @elastic/apm-ui (Team:apm) |
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
legrego
approved these changes
Nov 6, 2020
Member
legrego
left a comment
There was a problem hiding this comment.
Security/Spaces changes LGTM - tested locally
mikecote
approved these changes
Nov 6, 2020
Contributor
mikecote
left a comment
There was a problem hiding this comment.
Alerting team related code LGTM
igoristic
approved these changes
Nov 6, 2020
Contributor
igoristic
left a comment
There was a problem hiding this comment.
Tested locally, looks good from Stack Monitoring side
andrewvc
approved these changes
Nov 10, 2020
Contributor
|
Pinging @elastic/eui-design (EUI) |
shahzad31
approved these changes
Nov 16, 2020
Contributor
shahzad31
left a comment
There was a problem hiding this comment.
Uptime snapshots changes LGTM !!
poffdeluxe
approved these changes
Nov 16, 2020
Contributor
poffdeluxe
left a comment
There was a problem hiding this comment.
Presentation changes lgtm
patrykkopycinski
approved these changes
Nov 17, 2020
Contributor
patrykkopycinski
left a comment
There was a problem hiding this comment.
SIEM/Endpoint LGTM
Contributor
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
Page load bundle
Unknown metric groups@kbn/ui-shared-deps asset size
History
To update your PR or re-run it, just comment with: |
thompsongl
added a commit
to thompsongl/kibana
that referenced
this pull request
Nov 17, 2020
* eui to v30.2.0 * src snapshot updates * x-pack euipanel snapshot updates * x-pack external link updates * security_solution_cypress external link text * clean up
thompsongl
added a commit
that referenced
this pull request
Nov 18, 2020
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Nov 18, 2020
…o-node-details * 'master' of github.com:elastic/kibana: (65 commits) update chromedriver dependency to 87 (elastic#83624) [TSVB] use new Search API for rollup search (elastic#83275) [TSVB] Y-axis has number formatting not considering all series formatters in the group (elastic#83438) [Logs UI] Update <LogStream /> internal state when its props change (elastic#83302) Add tag bulk action context menu (elastic#82816) [code coverage] adding plugin to flush coverage data (elastic#83447) [UsageCollection] Expose `KibanaRequest` to explicitly opted-in collectors (elastic#83413) Added eventBus to trigger and listen plotHandler event (elastic#83435) [Runtime fields] Editor phase 1 (elastic#81472) [Maps] Fix threshold alert issue resolving nested fields (elastic#83577) chore(NA): remove usage of unverified es snapshots (elastic#83589) [DOCS] Adds Elastic Contributor Program link (elastic#83561) Upgrade EUI to v30.2.0 (elastic#82730) Don't show loading screen during auto-reload (elastic#83376) Functional tests - fix esArchive mappings with runtime fields (elastic#83530) [deb/rpm] Create keystore after installation (elastic#76465) [rpm] Create default environment file at "/etc/sysconfig/kibana" (elastic#82144) [docker] removes workaround for missing crypto-policies-scripts subpackage (elastic#83455) [ML] Persisted URL state for the Data frame analytics jobs and models pages (elastic#83439) adds xpack.security.authc.selector.enabled setting (elastic#83551) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eui@30.1.1⏩eui@30.2.0EuiPanelAPI means more CSS classes and therefore snapshot updatesEuiLinkfor external URLs means that "get element text" methods in test suites capture more text.removeExternalLinkTextis the current approach30.2.0labelWidthanddescriptionDisplayprops toEuiSuggestItem(#4180)EuiLinkopens in a new window (#4172)externalprop to true ifEuiLinkopens in a new window (#4172)floatandmarginprops toEuiImage(#4209)colorandborderRadiusprops toEuiPanel(#4194)EuiPanelprophasShadow(#4194)onClick,betaBadgeLabel,betaBadgeTooltipContent, andbetaBadgeTitleprops ofEuiPanel(#4194)Bug fixes
labelDisplaynot being passed toEuiSuggestItem(#4180)EuiDataGrid's header menu's sort actions (#4199)