[EuiSuggest] Fix labelDisplay and add labelWidth and descriptionDisplay props#4180
Merged
andreadelrio merged 10 commits intoelastic:masterfrom Oct 29, 2020
Merged
[EuiSuggest] Fix labelDisplay and add labelWidth and descriptionDisplay props#4180andreadelrio merged 10 commits intoelastic:masterfrom
andreadelrio merged 10 commits intoelastic:masterfrom
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4180/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4180/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4180/ |
cchaos
suggested changes
Oct 28, 2020
Contributor
cchaos
left a comment
There was a problem hiding this comment.
The only thing I see visually is that the wrapping version of the description could use some increase in line-height.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4180/ |
cchaos
approved these changes
Oct 28, 2020
Contributor
cchaos
left a comment
There was a problem hiding this comment.
Looks great. I just have one last suggestion as I was confirming the class name logic.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4180/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR:
labelDisplaywas not being passed fromEuiSuggesttoEuiSuggestItemlabelWidthprop so consumers can set label to a width lower or higher than 50%. The motivation behind this is a use case reported in Kibana where it seems like labels are unnecesarily taking up too much space as they are using the current default (i.e. 50%).descriptionDisplayprop to handle cases with really long descriptionsNote: Need to fix one failing test
Fixes #4173
Checklist
- [ ] Checked Code Sandbox works for the any docs examples- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes