Merged
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4209/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4209/ |
elizabetdev
approved these changes
Nov 2, 2020
Contributor
elizabetdev
left a comment
There was a problem hiding this comment.
It looks good. 🎉
I tested it locally and the float and margin seem to work as expected.
I just have a suggestion. I think the margin prop might be used out of context and for this reason we should probably rename it.
cchaos
pushed a commit
to andreadelrio/eui
that referenced
this pull request
Nov 4, 2020
Adds props for `float` and `margin` to `EuiImage`. This is needed for long-form text content, like documentation where an image compliments the text in an article format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds props for
floatandmargintoEuiImage. This is needed for long-form text content, like documentation where an image compliments the text in an article format.TODO:
Checklist