[App Search] Credentials: Add final Logic and server routes#81519
Merged
cee-chen merged 8 commits intoelastic:masterfrom Oct 22, 2020
Merged
[App Search] Credentials: Add final Logic and server routes#81519cee-chen merged 8 commits intoelastic:masterfrom
cee-chen merged 8 commits intoelastic:masterfrom
Conversation
Note: import reorder is required in for mocks to work correctly
+ some opinionated comments
cee-chen
commented
Oct 22, 2020
Comment on lines
+200
to
+201
| describe('validates', () => { | ||
| describe('admin keys', () => { |
Contributor
Author
There was a problem hiding this comment.
Note: this is copied/pasted from the new POST route tests. In theory we could DRY it out (since both routes inherit the same exact schema), but I didn't want to over-complicate it for now.
JasonStoltz
requested changes
Oct 22, 2020
Member
JasonStoltz
left a comment
There was a problem hiding this comment.
Nice work, quick turn around on this! There's a couple of small changes we may want to consider here.
...prise_search/public/applications/app_search/components/credentials/credentials_logic.test.ts
Outdated
Show resolved
Hide resolved
...prise_search/public/applications/app_search/components/credentials/credentials_logic.test.ts
Outdated
Show resolved
Hide resolved
...enterprise_search/public/applications/app_search/components/credentials/credentials_logic.ts
Show resolved
Hide resolved
...enterprise_search/public/applications/app_search/components/credentials/credentials_logic.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/enterprise_search/server/routes/app_search/credentials.ts
Show resolved
Hide resolved
…ked being undefined vs a bool
JasonStoltz
approved these changes
Oct 22, 2020
This was referenced Oct 22, 2020
Contributor
💚 Build SucceededMetrics [docs]async chunks size
History
To update your PR or re-run it, just comment with: |
cee-chen
pushed a commit
to cee-chen/kibana
that referenced
this pull request
Oct 26, 2020
…81519) * Add fullEngineAccessChecked logic * Add onEngineSelect logic * [Refactor] DRY out/simplify http mocks Note: import reorder is required in for mocks to work correctly * Add onApiTokenChange logic * Update flyout footer to use onApiTokenChange * Add new POST/PUT server routes + some opinionated comments * [PR feedback] tests copy, extra data tests * [PR feedback] Reuse fullEngineAccessChecked, fix fullEngineAccessChecked being undefined vs a bool
cee-chen
pushed a commit
that referenced
this pull request
Oct 26, 2020
…81540) * Add fullEngineAccessChecked logic * Add onEngineSelect logic * [Refactor] DRY out/simplify http mocks Note: import reorder is required in for mocks to work correctly * Add onApiTokenChange logic * Update flyout footer to use onApiTokenChange * Add new POST/PUT server routes + some opinionated comments * [PR feedback] tests copy, extra data tests * [PR feedback] Reuse fullEngineAccessChecked, fix fullEngineAccessChecked being undefined vs a bool Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR sequence
This PR is part of a set of 3 PRs that implements the Credentials flyout form + functionality. It's broken up into PRs in the 400-800 line range so as not to open a 1700~ line PR.
List of all PRs (may be helpful for obtaining more context / QAing the entire final feature)
Summary
This PR achieves:
CredentialsLogic.values.fullEngineAccessCheckedCredentialsLogic.actions.onEngineSelectCredentialsLogic.actions.onApiTokenChangeCredentialsLogic.actions.onApiTokenChangecalls:/api/app_search/credentials/api/app_search/credentials/{name}QA
This PR does not have easily testable changes in and of itself. It's easier to QA this against the
credentials-flyout-3branch.Checklist