[App Search] Credentials: add FlashMessages, stub out credentials flyout#81391
Merged
cee-chen merged 4 commits intoelastic:masterfrom Oct 22, 2020
Merged
[App Search] Credentials: add FlashMessages, stub out credentials flyout#81391cee-chen merged 4 commits intoelastic:masterfrom
cee-chen merged 4 commits intoelastic:masterfrom
Conversation
+ split out child sub components for easier testing/reading
- mostly just DELETE_MESSAGE currently, since that's what's already wired up - CREATE_MESSAGE and UPDATE_MESSAGE will be used in an upcoming commit + adds FlashMessages in flyout, which will show returned form errors from the API
e.g. deletion success messages + incidental linting/cleanup
Contributor
Author
|
@JasonStoltz highlighting 8211f17 - I'm going to be splitting a ton of the flyout/form into sub-components as part of my PRs because I strongly think it makes the code easier to read and easier to write tests for (vs a single massive test file). In particular IMO, this definitely pays off when unit testing individual form components (see PR 3). Let me know what you think! |
JasonStoltz
approved these changes
Oct 22, 2020
| import { i18n } from '@kbn/i18n'; | ||
|
|
||
| import { SetAppSearchChrome as SetPageChrome } from '../../../shared/kibana_chrome'; | ||
| import { FlashMessages } from '../../../shared/flash_messages'; |
Member
There was a problem hiding this comment.
Thanks, guess we missed these previously.
This was referenced Oct 22, 2020
Merged
cee-chen
pushed a commit
that referenced
this pull request
Oct 22, 2020
…out (#81391) (#81517) * Added an empty Flyout * Refactor CredentialsFlyout to its own component folder + split out child sub components for easier testing/reading * Add initial FlashMessages setup - mostly just DELETE_MESSAGE currently, since that's what's already wired up - CREATE_MESSAGE and UPDATE_MESSAGE will be used in an upcoming commit + adds FlashMessages in flyout, which will show returned form errors from the API * Fix flash messages appearing on flyout open e.g. deletion success messages + incidental linting/cleanup Co-authored-by: Jason Stoltzfus <jastoltz24@gmail.com> Co-authored-by: Jason Stoltzfus <jastoltz24@gmail.com>
17 tasks
Contributor
💚 Build SucceededMetrics [docs]@kbn/optimizer bundle module count
async chunks size
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR sequence
This PR is part of a set of 3 PRs that implements the Credentials flyout form + functionality. I broke it up into PRs in the 400-800 line range so as not to open a 1700~ line PR 😬
List of all PRs (may be helpful for obtaining more context / QAing the entire final feature)
Summary
This PR achieves:
Screencaps
QA
Checklist