Skip to content

[7.x] [App Search] Credentials: add FlashMessages, stub out credentials flyout (#81391)#81517

Merged
cee-chen merged 1 commit intoelastic:7.xfrom
cee-chen:backport/7.x/pr-81391
Oct 22, 2020
Merged

[7.x] [App Search] Credentials: add FlashMessages, stub out credentials flyout (#81391)#81517
cee-chen merged 1 commit intoelastic:7.xfrom
cee-chen:backport/7.x/pr-81391

Conversation

@cee-chen
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

…out (elastic#81391)

* Added an empty Flyout

* Refactor CredentialsFlyout to its own component folder
+ split out child sub components for easier testing/reading

* Add initial FlashMessages setup

- mostly just DELETE_MESSAGE currently, since that's what's already wired up
- CREATE_MESSAGE and UPDATE_MESSAGE will be used in an upcoming commit

+ adds FlashMessages in flyout, which will show returned form errors from the API

* Fix flash messages appearing on flyout open
e.g. deletion success messages

+ incidental linting/cleanup

Co-authored-by: Jason Stoltzfus <jastoltz24@gmail.com>
@cee-chen cee-chen added the backport This PR is a backport of another PR label Oct 22, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

id before after diff
enterpriseSearch 425 429 +4

async chunks size

id before after diff
enterpriseSearch 652.4KB 656.9KB +4.4KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cee-chen cee-chen merged commit 2937c2a into elastic:7.x Oct 22, 2020
@cee-chen cee-chen deleted the backport/7.x/pr-81391 branch October 22, 2020 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants