[7.x] [App Search] Credentials: Add final Logic and server routes (#81519)#81540
Merged
cee-chen merged 2 commits intoelastic:7.xfrom Oct 26, 2020
Merged
[7.x] [App Search] Credentials: Add final Logic and server routes (#81519)#81540cee-chen merged 2 commits intoelastic:7.xfrom
cee-chen merged 2 commits intoelastic:7.xfrom
Conversation
…81519) * Add fullEngineAccessChecked logic * Add onEngineSelect logic * [Refactor] DRY out/simplify http mocks Note: import reorder is required in for mocks to work correctly * Add onApiTokenChange logic * Update flyout footer to use onApiTokenChange * Add new POST/PUT server routes + some opinionated comments * [PR feedback] tests copy, extra data tests * [PR feedback] Reuse fullEngineAccessChecked, fix fullEngineAccessChecked being undefined vs a bool
9d37cea to
e18bb7b
Compare
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]async chunks size
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: