[Enterprise Search] Move renderHeaderActions back into mount useEffect#80861
Merged
cee-chen merged 1 commit intoelastic:masterfrom Oct 16, 2020
Merged
[Enterprise Search] Move renderHeaderActions back into mount useEffect#80861cee-chen merged 1 commit intoelastic:masterfrom
cee-chen merged 1 commit intoelastic:masterfrom
Conversation
Contributor
Author
|
@scottybollinger Thanks to Pierre's awesome work, this fix is now super easy on our end. Would you mind re-testing my QA steps in the PR description so that we can confirm it's working for more than just one person? |
scottybollinger
approved these changes
Oct 16, 2020
Contributor
scottybollinger
left a comment
There was a problem hiding this comment.
LGTM and all QA works as outlined 💯
Contributor
Author
|
Hooray! Thanks Scotty! |
Contributor
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
cee-chen
pushed a commit
to cee-chen/kibana
that referenced
this pull request
Oct 16, 2020
cee-chen
pushed a commit
to cee-chen/kibana
that referenced
this pull request
Oct 16, 2020
cee-chen
pushed a commit
that referenced
this pull request
Oct 16, 2020
cee-chen
pushed a commit
that referenced
this pull request
Oct 16, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 19, 2020
* master: (43 commits) [ML] Transforms: Fix tab ids for expanded row. (elastic#80666) server logs config paths to use for runner (elastic#52980) Fix audit logger logging to console even when disabled (elastic#80928) skip flaky suite (elastic#80929) Added Enterprise Search config to kibana-docker (elastic#80872) skip flaky suite (elastic#80914) [keystore_cli] parse values as JSON before adding to keystore (elastic#80848) [Ingest Manager] Fix for comparing versions with -SNAPSHOT suffix (elastic#80742) ECS audit logging (elastic#74640) [Uptime] Add client-side unit tests for remaining synthetics code (elastic#80215) [Security_Solution][Resolver] Promote z-index on node labels (elastic#80854) Move renderHeaderActions back into mount useEffect + update tests (elastic#80861) [Reporting] Document Network Policy configuration (elastic#80431) [Reporting] Add contextual documentation for CSV Max Bytes setting (elastic#80782) Add catch for Enterprise Search sending back a 401 response instead of redirect (elastic#80757) [Actions] Back Button on Add Connector Flyout (elastic#80160) removing `kibana_datatable` in favor of `datatable` (elastic#80548) [Alerting UI] Updating 'Add new' wording (elastic#80509) [Docs] Document Encrypted Saved Objects functionality. (elastic#80183) [Discover] fix auto-refresh (elastic#80635) ...
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 19, 2020
* master: (23 commits) [ML] Transforms: Fix tab ids for expanded row. (elastic#80666) server logs config paths to use for runner (elastic#52980) Fix audit logger logging to console even when disabled (elastic#80928) skip flaky suite (elastic#80929) Added Enterprise Search config to kibana-docker (elastic#80872) skip flaky suite (elastic#80914) [keystore_cli] parse values as JSON before adding to keystore (elastic#80848) [Ingest Manager] Fix for comparing versions with -SNAPSHOT suffix (elastic#80742) ECS audit logging (elastic#74640) [Uptime] Add client-side unit tests for remaining synthetics code (elastic#80215) [Security_Solution][Resolver] Promote z-index on node labels (elastic#80854) Move renderHeaderActions back into mount useEffect + update tests (elastic#80861) [Reporting] Document Network Policy configuration (elastic#80431) [Reporting] Add contextual documentation for CSV Max Bytes setting (elastic#80782) Add catch for Enterprise Search sending back a 401 response instead of redirect (elastic#80757) [Actions] Back Button on Add Connector Flyout (elastic#80160) removing `kibana_datatable` in favor of `datatable` (elastic#80548) [Alerting UI] Updating 'Add new' wording (elastic#80509) [Docs] Document Encrypted Saved Objects functionality. (elastic#80183) [Discover] fix auto-refresh (elastic#80635) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We originally moved
renderHeaderActions()outside of useEffect (3254c62) because it was disappearing between in-app navigation within Workplace Search. However, it turns out this was an issue with Kibana's internalnavigateToAppAPI which has now been fixed (#80809).We can now move
renderHeaderActions()back into our on-mount useEffect, which incidentally also solves the issue of our header actions not correctly unmounting when navigating outside the Workplace Search app.QA
yarn startand 'prod' (yarn start --no-base-path)Checklist