Fix a bug where header actions disappearing

scottybollinger · scottybollinger · commit 3254c6277e44 · 2020-09-30T13:30:32.000-05:00
There was a bug where changing routes would cause the header action, in the case of Workplace Search the “Go to search application” link, to disappear on route changes.

Turns out that we didn’t need it in the useEffect and that moving it out keeps the unmount from removing the link from the header.
diff --git a/x-pack/plugins/enterprise_search/public/applications/workplace_search/index.tsx b/x-pack/plugins/enterprise_search/public/applications/workplace_search/index.tsx
@@ -38,10 +38,11 @@ export const WorkplaceSearchConfigured: React.FC<IInitialAppData> = (props) => {
   useEffect(() => {
     if (!hasInitialized) {
       initializeAppData(props);
-      renderHeaderActions(WorkplaceSearchHeaderActions);
     }
   }, [hasInitialized]);
 
+  renderHeaderActions(WorkplaceSearchHeaderActions);
+
   return (
     <Switch>
       <Route path={SETUP_GUIDE_PATH}>
