removing kibana_datatable in favor of datatable #80548
Merged
ppisljar merged 23 commits intoelastic:masterfrom Oct 16, 2020
Merged
removing kibana_datatable in favor of datatable #80548ppisljar merged 23 commits intoelastic:masterfrom
kibana_datatable in favor of datatable #80548ppisljar merged 23 commits intoelastic:masterfrom
Conversation
# Conflicts: # src/plugins/vis_type_table/public/table_vis_fn.ts
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
in favor of datatable`
in favor of datatable` kibana_datatable in favor of datatable
0e20ca0 to
d54799c
Compare
Contributor
Author
|
@elasticmachine merge upstream |
lukeelmers
reviewed
Oct 15, 2020
Contributor
lukeelmers
left a comment
There was a problem hiding this comment.
Overall code LGTM here (I focused mainly on the app arch files and briefly reviewed the rest).
I updated the baselines for the interpreter functional tests, and as usual there are a few weird things in the screengrabs. Specifically:
test/interpreter_functional/screenshots/baseline/metric_invalid_data.png
- It feels like we had the wrong baseline here originally, as the added one from this PR looks like what I would expect.
test/interpreter_functional/screenshots/baseline/partial_test_3.png
- Map controls are now missing from this screengrab, not sure why?
Also on all of the screengrabs, the dimensions changed slightly after running on my machine. Not sure if this is correct; I guess we can wait and see if they pass.
Based on how finicky the screengrabs have been historically, I think we should continue to avoid adding new ones and prefer the snapshots instead whenever possible.
| const { indexPatternId, ...aggConfigs } = column.meta.sourceParams; | ||
| const indexPattern = await getIndexPatterns().get(indexPatternId); | ||
| const aggConfigsInstance = getSearchService().aggs.createAggConfigs(indexPattern, [ | ||
| aggConfigs as AggConfigSerialized, |
Contributor
There was a problem hiding this comment.
So I guess we need to cast here because the only constraints on the sourceParams is that it's serializable?
Contributor
There was a problem hiding this comment.
Maybe down the road we could look into introducing more specific typings for different sources. So that someone could do something like:
column.meta.sourceParams as EsaggsDatatableSourceParams
I guess this doesn't matter a ton though with the plan of moving toward utility functions, as most folks won't need to worry about these types at all.
Contributor
💚 Build SucceededMetrics [docs]@kbn/optimizer bundle module count
async chunks size
distributable file count
page load bundle size
History
To update your PR or re-run it, just comment with: |
flash1293
approved these changes
Oct 16, 2020
Contributor
flash1293
left a comment
There was a problem hiding this comment.
Tested and still seems to work fine in Lens
crob611
approved these changes
Oct 16, 2020
Contributor
crob611
left a comment
There was a problem hiding this comment.
Canvas changes look good 👍
lukeelmers
approved these changes
Oct 16, 2020
Contributor
lukeelmers
left a comment
There was a problem hiding this comment.
I guess the updated baselines worked! Code LGTM
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
Oct 16, 2020
ppisljar
added a commit
that referenced
this pull request
Oct 16, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 19, 2020
* master: (43 commits) [ML] Transforms: Fix tab ids for expanded row. (elastic#80666) server logs config paths to use for runner (elastic#52980) Fix audit logger logging to console even when disabled (elastic#80928) skip flaky suite (elastic#80929) Added Enterprise Search config to kibana-docker (elastic#80872) skip flaky suite (elastic#80914) [keystore_cli] parse values as JSON before adding to keystore (elastic#80848) [Ingest Manager] Fix for comparing versions with -SNAPSHOT suffix (elastic#80742) ECS audit logging (elastic#74640) [Uptime] Add client-side unit tests for remaining synthetics code (elastic#80215) [Security_Solution][Resolver] Promote z-index on node labels (elastic#80854) Move renderHeaderActions back into mount useEffect + update tests (elastic#80861) [Reporting] Document Network Policy configuration (elastic#80431) [Reporting] Add contextual documentation for CSV Max Bytes setting (elastic#80782) Add catch for Enterprise Search sending back a 401 response instead of redirect (elastic#80757) [Actions] Back Button on Add Connector Flyout (elastic#80160) removing `kibana_datatable` in favor of `datatable` (elastic#80548) [Alerting UI] Updating 'Add new' wording (elastic#80509) [Docs] Document Encrypted Saved Objects functionality. (elastic#80183) [Discover] fix auto-refresh (elastic#80635) ...
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 19, 2020
* master: (23 commits) [ML] Transforms: Fix tab ids for expanded row. (elastic#80666) server logs config paths to use for runner (elastic#52980) Fix audit logger logging to console even when disabled (elastic#80928) skip flaky suite (elastic#80929) Added Enterprise Search config to kibana-docker (elastic#80872) skip flaky suite (elastic#80914) [keystore_cli] parse values as JSON before adding to keystore (elastic#80848) [Ingest Manager] Fix for comparing versions with -SNAPSHOT suffix (elastic#80742) ECS audit logging (elastic#74640) [Uptime] Add client-side unit tests for remaining synthetics code (elastic#80215) [Security_Solution][Resolver] Promote z-index on node labels (elastic#80854) Move renderHeaderActions back into mount useEffect + update tests (elastic#80861) [Reporting] Document Network Policy configuration (elastic#80431) [Reporting] Add contextual documentation for CSV Max Bytes setting (elastic#80782) Add catch for Enterprise Search sending back a 401 response instead of redirect (elastic#80757) [Actions] Back Button on Add Connector Flyout (elastic#80160) removing `kibana_datatable` in favor of `datatable` (elastic#80548) [Alerting UI] Updating 'Add new' wording (elastic#80509) [Docs] Document Encrypted Saved Objects functionality. (elastic#80183) [Discover] fix auto-refresh (elastic#80635) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
kibana_datatableand makes all expression functions/renderers use same format ofdatatablefollowup:
reopens #75184, meta params are now removed from serialized field format.
Checklist
Delete any items that are not applicable to this PR.
For maintainers