-
Notifications
You must be signed in to change notification settings - Fork 8.5k
DatatableColumnMeta cleanup #78747
Copy link
Copy link
Closed
Labels
Feature:ExpressionLanguageInterpreter expression language (aka canvas pipeline)Interpreter expression language (aka canvas pipeline)impact:lowAddressing this issue will have a low level of impact on the quality/strength of our product.Addressing this issue will have a low level of impact on the quality/strength of our product.loe:smallSmall Level of EffortSmall Level of Effortv7.11.0v8.0.0
Metadata
Metadata
Assignees
Labels
Feature:ExpressionLanguageInterpreter expression language (aka canvas pipeline)Interpreter expression language (aka canvas pipeline)impact:lowAddressing this issue will have a low level of impact on the quality/strength of our product.Addressing this issue will have a low level of impact on the quality/strength of our product.loe:smallSmall Level of EffortSmall Level of Effortv7.11.0v8.0.0
Type
Fields
Give feedbackNo fields configured for issues without a type.
DatatableColumnMeta currently has the following type:
two things are a bit unclear here:
stringandmeta.params.idisnumberthere are two options for the cleanup:
we would remove fieldType information (which is currently on meta.type) and replace it with field format id. This way its clear what the actual format is, and current fieldTypes in use are subset of available field formatters. The structure gets simplified and fieldType information is anyway redundant as we already have meta.field and meta.index with which we can find out the actual fieldType.
the new DatatableColumnMeta would become:
meta.paramstometa.formatandmeta.sourceParamstometa.paramswe would keep the redundant fieldType information (
meta.type) but rather renamemeta.paramsto be more semantic intometa.formatwhich would still be whole SerializedFieldFormat. There is still unclear which type to use (meta.type or meta.format.id) and they may still be incompatible, but at least we have a bit more semantic naming.