Skip to content

[Maps] Support envelope#80614

Merged
thomasneirynck merged 2 commits intoelastic:masterfrom
thomasneirynck:maps/support_envelope
Oct 15, 2020
Merged

[Maps] Support envelope#80614
thomasneirynck merged 2 commits intoelastic:masterfrom
thomasneirynck:maps/support_envelope

Conversation

@thomasneirynck
Copy link
Copy Markdown
Contributor

@thomasneirynck thomasneirynck commented Oct 15, 2020 •
edited
Loading

Summary

Closes #80613

This adds display-support of ES-envelopes to Kibana Maps.

image

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@thomasneirynck thomasneirynck requested a review from a team as a code owner October 15, 2020 05:30
@thomasneirynck thomasneirynck changed the title support envelope [Maps] Support envelope Oct 15, 2020
@thomasneirynck thomasneirynck added release_note:enhancement Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.11.0 v8.0.0 labels Oct 15, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 15, 2020

Pinging @elastic/kibana-gis (Team:Geo)

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 15, 2020

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
maps 3.2MB 3.2MB +243.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kindsun
kindsun approved these changes Oct 15, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@kindsun kindsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! 👍

image

lgtm!

  • code review
  • tested locally in chrome

@thomasneirynck thomasneirynck merged commit b1af4ba into elastic:master Oct 15, 2020
@thomasneirynck thomasneirynck mentioned this pull request Oct 15, 2020
Merged
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Oct 15, 2020
@thomasneirynck
[Maps] Add support for envelope (elastic#80614)
4a783de
thomasneirynck added a commit that referenced this pull request Oct 15, 2020
@thomasneirynck
[Maps] Add support for envelope (#80614) (#80725)
0c7099a
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 16, 2020
@gmmorris
Merge branch 'master' into task-manager/refactor-oversized-class
475d49d 
* master: (115 commits)
  [ML] Transforms/DF Analytics: Fix data grid column sorting. (elastic#80618)
  added brace import to vis editor (elastic#80652)
  Fix error rate sorting in services list (elastic#80764)
  Emit info log when using custom registry URL (elastic#80768)
  [Reporting] Config Schema Validation for rules[N].protocol strings (elastic#80766)
  Add Storybook a11y addon (elastic#80069)
  Fix anomaly alert selection text (elastic#80746)
  [Security Solution] [Maps] Kibana index pattern, comma bug fix (elastic#80208)
  [kbn/optimizer] tweak split chunks options (elastic#80444)
  update template to use the new team label (elastic#80748)
  [Security Solution] Fix the Field dropdown in Timeline data providers resets when scrolled (elastic#80718)
  Adjusts observability alerting perms to require "all" (elastic#79896)
  [Security Solutions][Detection Engine] Fixes pre-packaged rules which contain exception lists to not overwrite user defined lists   (elastic#80592)
  [data.ui] Fix flaky test & lazy loading rendering artifacts. (elastic#80612)
  Licensed feature usage for connectors (elastic#77679)
  [Security Solution] Cypress template creation (elastic#80180)
  [APM] Hide service if only data is from ML (elastic#80145)
  Fix role mappings test for ESS (elastic#80604)
  [Maps] Add support for envelope (elastic#80614)
  [Security Solution] Update button text according to status (elastic#80389)
  ...
@bhavyarm
Copy link
Copy Markdown
Contributor

bhavyarm commented Jan 13, 2021

Hey team - can I please get some sample data documents to test this? Thanks!

@bhavyarm
Copy link
Copy Markdown
Contributor

bhavyarm commented Jan 13, 2021

Thanks @thomasneirynck

PUT /example
{
  "mappings": {
    "properties": {
      "location": {
        "type": "geo_shape"
      }
    }
  }
}
POST /example/_doc
{
  "location" : {
    "type" : "envelope",
    "coordinates" : [ [100.0, 1.0], [101.0, 0.0] ]
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nreese nreese Awaiting requested review from nreese

1 more reviewer

@kindsun kindsun kindsun approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release_note:enhancement Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.11.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Maps] Support envelope geometry-type

5 participants

@thomasneirynck @elasticmachine @kibanamachine @bhavyarm @kindsun