Skip to content

Licensed feature usage for connectors#77679

Merged
mikecote merged 23 commits intoelastic:masterfrom
mikecote:actions/feature-usage
Oct 15, 2020
Merged

Licensed feature usage for connectors#77679
mikecote merged 23 commits intoelastic:masterfrom
mikecote:actions/feature-usage

Conversation

@mikecote
Copy link
Copy Markdown
Contributor

@mikecote mikecote commented Sep 16, 2020

Resolves #64849

In this PR, I'm adding licensed usage to the connectors. The usage will be tracked at the following places:

  • Executing a connector (via HTTP API and via plugin API)
  • Enqueuing an execution (via plugin API)
  • Actions client (Create, Update)
  • Alert create / update (notify per action)

@mikecote mikecote added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Actions Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v7.10.0 labels Sep 16, 2020
@mikecote mikecote self-assigned this Sep 16, 2020
@mikecote mikecote marked this pull request as ready for review September 29, 2020 19:24
@mikecote mikecote requested a review from a team as a code owner September 29, 2020 19:24
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

Copy link
Copy Markdown
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikecote
Copy link
Copy Markdown
Contributor Author

mikecote commented Oct 1, 2020

@elasticmachine merge upstream

@mikecote
Copy link
Copy Markdown
Contributor Author

mikecote commented Oct 1, 2020

@elasticmachine merge upstream

@mikecote
Copy link
Copy Markdown
Contributor Author

mikecote commented Oct 2, 2020

@elasticmachine merge upstream

@pmuellr pmuellr added v7.11.0 and removed v7.10.0 labels Oct 8, 2020
Copy link
Copy Markdown
Contributor

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; made a comment about a comment

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

distributable file count

id before after diff
default 48495 48496 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mikecote mikecote merged commit 3ad698d into elastic:master Oct 15, 2020
mikecote added a commit to mikecote/kibana that referenced this pull request Oct 15, 2020
* Initial work

* Fix type check and jest failures

* Add unit tests

* No need to notifyUsage from alert execution handler

* Fix ESLint

* Log action usage from alerts

* Add integration tests

* Fix jest test

* Skip feature usage of basic action types

* Fix types

* Fix ESLint issue

* Clarify comment

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
mikecote added a commit that referenced this pull request Oct 15, 2020
* Initial work

* Fix type check and jest failures

* Add unit tests

* No need to notifyUsage from alert execution handler

* Fix ESLint

* Log action usage from alerts

* Add integration tests

* Fix jest test

* Skip feature usage of basic action types

* Fix types

* Fix ESLint issue

* Clarify comment

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 16, 2020
* master: (115 commits)
  [ML] Transforms/DF Analytics: Fix data grid column sorting. (elastic#80618)
  added brace import to vis editor (elastic#80652)
  Fix error rate sorting in services list (elastic#80764)
  Emit info log when using custom registry URL (elastic#80768)
  [Reporting] Config Schema Validation for rules[N].protocol strings (elastic#80766)
  Add Storybook a11y addon (elastic#80069)
  Fix anomaly alert selection text (elastic#80746)
  [Security Solution] [Maps] Kibana index pattern, comma bug fix (elastic#80208)
  [kbn/optimizer] tweak split chunks options (elastic#80444)
  update template to use the new team label (elastic#80748)
  [Security Solution] Fix the Field dropdown in Timeline data providers resets when scrolled (elastic#80718)
  Adjusts observability alerting perms to require "all" (elastic#79896)
  [Security Solutions][Detection Engine] Fixes pre-packaged rules which contain exception lists to not overwrite user defined lists   (elastic#80592)
  [data.ui] Fix flaky test & lazy loading rendering artifacts. (elastic#80612)
  Licensed feature usage for connectors (elastic#77679)
  [Security Solution] Cypress template creation (elastic#80180)
  [APM] Hide service if only data is from ML (elastic#80145)
  Fix role mappings test for ESS (elastic#80604)
  [Maps] Add support for envelope (elastic#80614)
  [Security Solution] Update button text according to status (elastic#80389)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Actions release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v7.11.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Licensed feature usage - alerts and actions

5 participants