Skip to content

Add Storybook a11y addon#80069

Merged
smith merged 14 commits intoelastic:masterfrom
smith:nls/sb-a11y
Oct 15, 2020
Merged

Add Storybook a11y addon#80069
smith merged 14 commits intoelastic:masterfrom
smith:nls/sb-a11y

Conversation

@smith
Copy link
Copy Markdown
Contributor

@smith smith commented Oct 8, 2020

Add an Accessibility tab to Storybooks.

image

Also upgrade to latest point release of Storybook and remove duplicate dependencies from kbn-storybook's package.json.

@smith smith added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Oct 8, 2020
@smith smith mentioned this pull request Oct 8, 2020
11 tasks
@smith smith requested a review from spalger October 9, 2020 03:40
Copy link
Copy Markdown
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though now that kbn/storybook has no production dependencies its yarn.lock file needs to go too

@smith smith requested review from a team as code owners October 11, 2020 23:42
@smith
Copy link
Copy Markdown
Contributor Author

smith commented Oct 13, 2020

@elasticmachine merge upstream

Copy link
Copy Markdown
Contributor

@clintandrewhall clintandrewhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
enterpriseSearch 661.8KB 662.1KB +309.0B

page load bundle size

id before after diff
upgradeAssistant 64.7KB 65.0KB +309.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@smith smith merged commit 5f3e2c0 into elastic:master Oct 15, 2020
@smith smith deleted the nls/sb-a11y branch October 15, 2020 22:25
smith added a commit to smith/kibana that referenced this pull request Oct 15, 2020
smith added a commit that referenced this pull request Oct 16, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 16, 2020
* master: (115 commits)
  [ML] Transforms/DF Analytics: Fix data grid column sorting. (elastic#80618)
  added brace import to vis editor (elastic#80652)
  Fix error rate sorting in services list (elastic#80764)
  Emit info log when using custom registry URL (elastic#80768)
  [Reporting] Config Schema Validation for rules[N].protocol strings (elastic#80766)
  Add Storybook a11y addon (elastic#80069)
  Fix anomaly alert selection text (elastic#80746)
  [Security Solution] [Maps] Kibana index pattern, comma bug fix (elastic#80208)
  [kbn/optimizer] tweak split chunks options (elastic#80444)
  update template to use the new team label (elastic#80748)
  [Security Solution] Fix the Field dropdown in Timeline data providers resets when scrolled (elastic#80718)
  Adjusts observability alerting perms to require "all" (elastic#79896)
  [Security Solutions][Detection Engine] Fixes pre-packaged rules which contain exception lists to not overwrite user defined lists   (elastic#80592)
  [data.ui] Fix flaky test & lazy loading rendering artifacts. (elastic#80612)
  Licensed feature usage for connectors (elastic#77679)
  [Security Solution] Cypress template creation (elastic#80180)
  [APM] Hide service if only data is from ML (elastic#80145)
  Fix role mappings test for ESS (elastic#80604)
  [Maps] Add support for envelope (elastic#80614)
  [Security Solution] Update button text according to status (elastic#80389)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants