[Security Solution][Case] Fix bug when changing connectors#80002
Merged
cnasikas merged 1 commit intoelastic:masterfrom Oct 9, 2020
Merged
[Security Solution][Case] Fix bug when changing connectors#80002cnasikas merged 1 commit intoelastic:masterfrom
cnasikas merged 1 commit intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
819e534 to
5d55b14
Compare
Member
Author
|
@elasticmachine merge upstream |
stephmilovic
reviewed
Oct 8, 2020
stephmilovic
approved these changes
Oct 8, 2020
Contributor
stephmilovic
left a comment
There was a problem hiding this comment.
Thank you for the bug fix and the thorough test coverage. LGTM!
4de4012 to
234ea50
Compare
234ea50 to
ef85273
Compare
Contributor
💚 Build SucceededMetrics [docs]async chunks size
History
To update your PR or re-run it, just comment with: |
cnasikas
added a commit
to cnasikas/kibana
that referenced
this pull request
Oct 9, 2020
cnasikas
added a commit
that referenced
this pull request
Oct 9, 2020
cnasikas
added a commit
that referenced
this pull request
Oct 9, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 12, 2020
* master: (23 commits) Table visualization renderer (elastic#79455) Migrate Jest JUnit reporter to TS (elastic#79919) store sorted bundleRefExportIds (elastic#80011) update chromedriver dependency to 86.0.0 (elastic#79972) [Security Solution][Case] Fix bug when changing connectors (elastic#80002) [kbn/std] add observable helpers to aid with rxjs 7 upgrade (elastic#79752) [Security Solution][Resolver] Pill numbers in compact notation (elastic#80038) [Logs UI] Sync logs timerange with wider Kibana (elastic#79444) [DOCS] Adds quick start (elastic#78822) [Ingest Manager]Fix ingest manager UI renaming (elastic#80036) [Monitoring] Fixed internal monitoring check (elastic#79241) [Security Solution][Exception Modal] Removes list operators in exception modal for EQL rules (elastic#79871) Update development documentation about REST API best practices (elastic#80009) [Monitoring] Improve indices loading against larger metricbeat-* indices (elastic#79190) [CI] Move kibana build dir outside of repo for functional tests (elastic#80018) [kbn/optimizer] bump low or add missing limits when updating automatically (elastic#80013) [Enterprise Search] Added a Credentials page to App Search (elastic#79749) [DOCS] Canvas refresh for 7.10 (elastic#80017) [TSVB] Add ignore global filters to series options (elastic#79337) Remove this check (elastic#79202) ...
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR closes #79833.
When you change a connector and at the same time you change a field you cannot push the new changes to the connector. You need to do it in two steps, first, change the connector and then change the field.
This PR fixes this issue.
Checklist
Delete any items that are not applicable to this PR.
For maintainers