[Monitoring] Improve indices loading against larger metricbeat-* indices#79190
Merged
chrisronline merged 4 commits intoelastic:masterfrom Oct 8, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/stack-monitoring (Team:Monitoring) |
…its_unmapped_type
igoristic
reviewed
Oct 8, 2020
Contributor
igoristic
left a comment
There was a problem hiding this comment.
@chrisronline This looks good, but then shouldn't we do this for all our queries that are doing sort on timestamp (and maybe even other fields where we do sorting)?
I was actually thinking maybe we can have appendMetricbeatIndex return an empty string temporarily (until it actually works), wdyt?
Contributor
Author
|
I updated the all |
Contributor
💚 Build SucceededMetrics [docs]async chunks size
History
To update your PR or re-run it, just comment with: |
igoristic
approved these changes
Oct 8, 2020
Contributor
igoristic
left a comment
There was a problem hiding this comment.
Awesome job! ...and great discovery/fix! 👏
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 12, 2020
* master: (23 commits) Table visualization renderer (elastic#79455) Migrate Jest JUnit reporter to TS (elastic#79919) store sorted bundleRefExportIds (elastic#80011) update chromedriver dependency to 86.0.0 (elastic#79972) [Security Solution][Case] Fix bug when changing connectors (elastic#80002) [kbn/std] add observable helpers to aid with rxjs 7 upgrade (elastic#79752) [Security Solution][Resolver] Pill numbers in compact notation (elastic#80038) [Logs UI] Sync logs timerange with wider Kibana (elastic#79444) [DOCS] Adds quick start (elastic#78822) [Ingest Manager]Fix ingest manager UI renaming (elastic#80036) [Monitoring] Fixed internal monitoring check (elastic#79241) [Security Solution][Exception Modal] Removes list operators in exception modal for EQL rules (elastic#79871) Update development documentation about REST API best practices (elastic#80009) [Monitoring] Improve indices loading against larger metricbeat-* indices (elastic#79190) [CI] Move kibana build dir outside of repo for functional tests (elastic#80018) [kbn/optimizer] bump low or add missing limits when updating automatically (elastic#80013) [Enterprise Search] Added a Credentials page to App Search (elastic#79749) [DOCS] Canvas refresh for 7.10 (elastic#80017) [TSVB] Add ignore global filters to series options (elastic#79337) Remove this check (elastic#79202) ...
Member
|
The issue is having major impact. Is it feasible to backport this PR to 7.10? |
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Feb 4, 2021
…ces (elastic#79190) * Improve indices loading against larger metricbeat-* indices * PR feedback
Contributor
Author
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #78668
This is difficult to test because in the various attempts we made to figure out the issue, we added a mapping to all
metricbeat-*indices that fixes it across the board and we are unable to back out of that mapping addition without reindexing.I'll open this PR for now and think through how we can properly test this