Skip to content

Migrate Jest JUnit reporter to TS#79919

Merged
tylersmalley merged 5 commits intoelastic:masterfrom
tylersmalley:jest-reporter
Oct 12, 2020
Merged

Migrate Jest JUnit reporter to TS#79919
tylersmalley merged 5 commits intoelastic:masterfrom
tylersmalley:jest-reporter

Conversation

@tylersmalley
Copy link
Copy Markdown
Member

@tylersmalley tylersmalley commented Oct 7, 2020

Migrates the Jest JUnit reporter to Typescript. This exposed issues with the reporter where incorrect options or properties were used. Additionally, this moves the reporter to the @kbn/test package.

@tylersmalley tylersmalley force-pushed the jest-reporter branch 2 times, most recently from 6a51854 to e5ec519 Compare October 8, 2020 06:43
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was incorrect property.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱

Copy link
Copy Markdown
Member Author

@tylersmalley tylersmalley Oct 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was incorrect option.

Also moves reporter to @kbn/test package

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley tylersmalley changed the title Converts Jest JUnit reporter to TS Migrate Jest JUnit reporter to TS Oct 8, 2020
@tylersmalley tylersmalley added Team:Operations Kibana-Operations Team v7.11.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Oct 8, 2020
@tylersmalley tylersmalley marked this pull request as ready for review October 8, 2020 13:54
@tylersmalley tylersmalley requested a review from a team as a code owner October 8, 2020 13:54
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

Copy link
Copy Markdown
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I also deduped some of the installed packages 👍

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley
Copy link
Copy Markdown
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tylersmalley tylersmalley merged commit 92bb8e7 into elastic:master Oct 12, 2020
tylersmalley added a commit to tylersmalley/kibana that referenced this pull request Oct 12, 2020
* Converts Jest JUnit reporter to TS

Also moves reporter to @kbn/test package

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
# Conflicts:
#	packages/kbn-test/src/jest/junit_reporter.ts
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 12, 2020
* master: (23 commits)
  Table visualization renderer (elastic#79455)
  Migrate Jest JUnit reporter to TS (elastic#79919)
  store sorted bundleRefExportIds (elastic#80011)
  update chromedriver dependency to 86.0.0 (elastic#79972)
  [Security Solution][Case] Fix bug when changing connectors (elastic#80002)
  [kbn/std] add observable helpers to aid with rxjs 7 upgrade (elastic#79752)
  [Security Solution][Resolver] Pill numbers in compact notation (elastic#80038)
  [Logs UI] Sync logs timerange with wider Kibana (elastic#79444)
  [DOCS] Adds quick start (elastic#78822)
  [Ingest Manager]Fix ingest manager UI renaming (elastic#80036)
  [Monitoring] Fixed internal monitoring check (elastic#79241)
  [Security Solution][Exception Modal] Removes list operators in exception modal for EQL rules (elastic#79871)
  Update development documentation about REST API best practices (elastic#80009)
  [Monitoring] Improve indices loading against larger metricbeat-* indices (elastic#79190)
  [CI] Move kibana build dir outside of repo for functional tests (elastic#80018)
  [kbn/optimizer] bump low or add missing limits when updating automatically (elastic#80013)
  [Enterprise Search] Added a Credentials page to App Search (elastic#79749)
  [DOCS] Canvas refresh for 7.10 (elastic#80017)
  [TSVB] Add ignore global filters to series options (elastic#79337)
  Remove this check (elastic#79202)
  ...
tylersmalley added a commit that referenced this pull request Oct 12, 2020
* Converts Jest JUnit reporter to TS

Also moves reporter to @kbn/test package

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
# Conflicts:
#	packages/kbn-test/src/jest/junit_reporter.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.11.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants