[Ingest Manager] Update open API spec and add condition to agent upgrade endpoint#79579
Merged
neptunian merged 2 commits intoelastic:masterfrom Oct 6, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
nchaulet
reviewed
Oct 5, 2020
| request.params.agentId | ||
| ); | ||
| if (agent.attributes.unenrollment_started_at || agent.attributes.unenrolled_at) { | ||
| if (agentSO.attributes.unenrollment_started_at || agentSO.attributes.unenrolled_at) { |
Member
There was a problem hiding this comment.
we also have the .active = false property when an agent is unenrolled that I will trust more than these two field
Contributor
Author
There was a problem hiding this comment.
I used this because it was used here to get unenrolled or unenrolling and because active doesn't get set to false until after unenrollment. Going to merge but will review when we do the status refactor.
Contributor
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
jfsiii
approved these changes
Oct 5, 2020
Contributor
jfsiii
left a comment
There was a problem hiding this comment.
I'm not 💯 on the OpenAPI definitions, but they can be updated later. The important thing, IMO, is the new tests.
neptunian
added a commit
to neptunian/kibana
that referenced
this pull request
Oct 6, 2020
…ade endpoint (elastic#79579) * add condition to check for upgradeable agent to endpoint * update the openAPI spec
gmmorris
added a commit
that referenced
this pull request
Oct 8, 2020
…into feature/task_manager_429 * 'feature/task_manager_429' of github.com:elastic/kibana: (158 commits) Add license check to direct package upload handler. (#79653) [Ingest Manager] Rename API /api/ingest_manager => /api/fleet (#79193) [Security Solution][Resolver] Simplify CopyableField styling and add comments (#79594) Fine-tunes ML related text on Metrics UI (#79425) [ML] DF Analytics creation wizard: ensure job creation possible when model memory lower than estimate (#79229) Add new "Add Data" tutorials (#77237) Update APM telemetry docs (#79583) Revert "Add support for runtime field types to mappings editor. (#77420)" (#79611) Kibana request headers (#79218) ensure missing indexPattern error is bubbled up to error callout (#79378) Missing space fix (#79585) remove duplicate tab states (#79501) [data.ui] Lazy load UI components in data plugin. (#78889) Add generic type params to search dependency. (#79608) [Ingest Manager] Internal action for policy reassign (#78493) [ILM] Add index_codec to forcemerge action in hot and warm phases (#78175) [Ingest Manager] Update open API spec and add condition to agent upgrade endpoint (#79579) [ML] Hide Data Grid column options when histogram charts are enabled. (#79459) [Telemetry] Synchronous `setup` and `start` methods (#79457) [Observability] Persist time range across apps (#79258) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple changes to follow up #78810
fleet/agents/bulk_upgradeandfleet/{agentId}/upgradeisUpgradeablecheck tofleet/{agentId}/upgrade. We useisUpgradeablein the UI to check if an agent can be upgraded, but it was not added to the endpoint. This adds the condition and some integration tests to check for it.