[ML] Hide Data Grid column options when histogram charts are enabled.#79459
Merged
peteharverson merged 3 commits intoelastic:masterfrom Oct 6, 2020
Merged
[ML] Hide Data Grid column options when histogram charts are enabled.#79459peteharverson merged 3 commits intoelastic:masterfrom
peteharverson merged 3 commits intoelastic:masterfrom
Conversation
Contributor
Author
|
@chandlerprall would be great if you can ping @peteharverson once EUI v29.3.0 is in |
Contributor
|
@peteharverson the EUI v29.3.0 PR has merged into |
Contributor
|
@elasticmachine merge upstream |
Contributor
|
Pinging @elastic/ml-ui (:ml) |
Contributor
💚 Build SucceededMetrics [docs]async chunks size
History
To update your PR or re-run it, just comment with: |
peteharverson
pushed a commit
to peteharverson/kibana
that referenced
this pull request
Oct 6, 2020
…elastic#79459) * [ML] Fix data grid actions. * [ML] fix columnsWithChartsActionized Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
peteharverson
added a commit
that referenced
this pull request
Oct 6, 2020
…#79459) (#79640) * [ML] Fix data grid actions. * [ML] fix columnsWithChartsActionized Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co> Co-authored-by: Walter Rafelsberger <walter@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
gmmorris
added a commit
that referenced
this pull request
Oct 8, 2020
…into feature/task_manager_429 * 'feature/task_manager_429' of github.com:elastic/kibana: (158 commits) Add license check to direct package upload handler. (#79653) [Ingest Manager] Rename API /api/ingest_manager => /api/fleet (#79193) [Security Solution][Resolver] Simplify CopyableField styling and add comments (#79594) Fine-tunes ML related text on Metrics UI (#79425) [ML] DF Analytics creation wizard: ensure job creation possible when model memory lower than estimate (#79229) Add new "Add Data" tutorials (#77237) Update APM telemetry docs (#79583) Revert "Add support for runtime field types to mappings editor. (#77420)" (#79611) Kibana request headers (#79218) ensure missing indexPattern error is bubbled up to error callout (#79378) Missing space fix (#79585) remove duplicate tab states (#79501) [data.ui] Lazy load UI components in data plugin. (#78889) Add generic type params to search dependency. (#79608) [Ingest Manager] Internal action for policy reassign (#78493) [ILM] Add index_codec to forcemerge action in hot and warm phases (#78175) [Ingest Manager] Update open API spec and add condition to agent upgrade endpoint (#79579) [ML] Hide Data Grid column options when histogram charts are enabled. (#79459) [Telemetry] Synchronous `setup` and `start` methods (#79457) [Observability] Persist time range across apps (#79258) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Quick fix for #79066.
EUI v29.3.0 introduces new column actions for
EuiDataGrid.The default layout with the vertical alignment of the action icon doesn't play well with the custom histogram charts we added to the Data Frame Analytics and Transform Wizard data grids.
The PR is a quick fix to disable and hide the columns actions when the histogram charts are enabled. We can think of a better design in a followup.
Checklist
For maintainers