[Ingest pipelines] Fix duplicate tab states#79501
Merged
alisonelizabeth merged 2 commits intoelastic:masterfrom Oct 6, 2020
Merged
[Ingest pipelines] Fix duplicate tab states#79501alisonelizabeth merged 2 commits intoelastic:masterfrom
alisonelizabeth merged 2 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
jloleysens
approved these changes
Oct 6, 2020
Contributor
jloleysens
left a comment
There was a problem hiding this comment.
Great catch @alisonelizabeth !
I wonder if this is something we can make more robust down the line by investigating the use of the shared GlobalFlyout component.
I also noticed the build reported a large number of bundling changes - not quite sure how this is showing up here from the changes you made, so going to assume this is unrelated for now.
Contributor
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]async chunks size
History
To update your PR or re-run it, just comment with: |
Contributor
Author
|
Thanks @jloleysens for the review! Yes, I agree; I think it's worth looking into using the global flyout. I started some initial investigation on this awhile back, but need to pick it back up. |
alisonelizabeth
added a commit
that referenced
this pull request
Oct 6, 2020
gmmorris
added a commit
that referenced
this pull request
Oct 8, 2020
…into feature/task_manager_429 * 'feature/task_manager_429' of github.com:elastic/kibana: (158 commits) Add license check to direct package upload handler. (#79653) [Ingest Manager] Rename API /api/ingest_manager => /api/fleet (#79193) [Security Solution][Resolver] Simplify CopyableField styling and add comments (#79594) Fine-tunes ML related text on Metrics UI (#79425) [ML] DF Analytics creation wizard: ensure job creation possible when model memory lower than estimate (#79229) Add new "Add Data" tutorials (#77237) Update APM telemetry docs (#79583) Revert "Add support for runtime field types to mappings editor. (#77420)" (#79611) Kibana request headers (#79218) ensure missing indexPattern error is bubbled up to error callout (#79378) Missing space fix (#79585) remove duplicate tab states (#79501) [data.ui] Lazy load UI components in data plugin. (#78889) Add generic type params to search dependency. (#79608) [Ingest Manager] Internal action for policy reassign (#78493) [ILM] Add index_codec to forcemerge action in hot and warm phases (#78175) [Ingest Manager] Update open API spec and add condition to agent upgrade endpoint (#79579) [ML] Hide Data Grid column options when histogram charts are enabled. (#79459) [Telemetry] Synchronous `setup` and `start` methods (#79457) [Observability] Persist time range across apps (#79258) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I inadvertently was keeping track of the active tab state for the test pipeline flyout in two places 😬. This could cause an issue on large screens - if you had the flyout open with the "Output" tab active, and then try to click on the documents dropdown to edit documents, it would have no effect.
With the fix, you can now click "Edit documents" and the flyout will change to the appropriate tab:
