upgrade chromedriver 2.21.2 -> 2.22.1 by ppisljar · Pull Request #7859 · elastic/kibana

ppisljar · 2016-07-27T15:20:41Z

tests involving alert or confirm boxes were failing for me with "unexpected alert box" error message.

it also happened at CI ... but cant find that log now.

ppisljar · 2016-07-28T10:05:21Z

jenkins, test this

ppisljar · 2016-07-28T11:03:43Z

@LeeDr can you reproduce this error on your end ?

LeeDr · 2016-07-28T15:03:11Z

Here's a link to the jenkins test failure;
https://kibana-ci.elastic.co/job/elastic+kibana+pull-request+multijob-selenium/61/consoleFull

And a bit of that log in case it gets cleaned up;

>> PASS: chrome on any platform - settings app - index result field sort - sort by heading - name - should sort ascending (490ms)
14:17:07.040: tryForTime failure: [GET http://localhost:4444/wd/hub/session/220e6f2a10e9a3ca86a35ad97cf56482/alert_text] unknown error: cannot determine loading status
from unexpected alert open
  (Session info: chrome=51.0.2704.106)
  (Driver info: chromedriver=2.21.371461 (633e689b520b25f3e264a2ede6b74ccc23cb636a),platform=Linux 3.13.0-74-generic x86_64)
14:17:07.549: tryForTime failure: [POST http://localhost:4444/wd/hub/session/220e6f2a10e9a3ca86a35ad97cf56482/element / {"using":"css selector","value":"button.btn.btn-danger.ng-scope"}] unexpected alert open: {Alert text : Are you sure you want to remove this index pattern?}
  (Session info: chrome=51.0.2704.106)
  (Driver info: chromedriver=2.21.371461 (633e689b520b25f3e264a2ede6b74ccc23cb636a),platform=Linux 3.13.0-74-generic x86_64)
14:17:08.058: tryForTime failure: [POST http://localhost:4444/wd/hub/session/220e6f2a10e9a3ca86a35ad97cf56482/element / {"using":"css selector","value":"button.btn.btn-danger.ng-scope"}] unexpected alert open: {Alert text : Are you sure you want to remove this index pattern?}

I was able to reproduce the problem on a Ubuntu VM, but only about 1 in 5 runs of the management tests caused it. I've experimented with a couple of different changes to narrow down the problem, try to work-around it, and capture details to file an issue on Intern (or for chromedriver).
I don't have anything concrete yet...

FYI, I run the tests in a loop like this so that it stops when it fails;

# in one shell start the ui:server
npm run test:ui:server

# in another shell run just the management tests in a loop until they fail
export count=0; while ( time npm run test:ui:runner -- --appSuites=management ); do let count=count+1; echo $count; sleep 5; done

LeeDr · 2016-07-29T20:18:57Z

jenkins, test this

LeeDr · 2016-08-01T15:33:33Z

The tests passed on the last build. Test again. jenkins, test this

LeeDr · 2016-08-01T15:33:41Z

jenkins, test this

LeeDr · 2016-08-01T15:35:59Z

@ppisljar Can you confirm you've run the management (or all the functional tests) a few times locally and they pass with chromedriver 2.18.0 ?

LeeDr · 2016-08-01T17:36:35Z

Another test passed. Testing again.

LeeDr · 2016-08-01T17:36:46Z

jenkins, test this

ppisljar · 2016-08-01T18:22:17Z

i can confirm. i ran tests 5 times in a row and they always passed

LeeDr · 2016-08-01T18:24:16Z

LGTM

I tested with the downgraded chromedriver locally and tests are passing on jenkins-ci. In the last build/test on jenkins the tests passed but there was a timeout updating github;

Finished Build : #173 of Job : elastic+kibana+pull-request+multijob-selenium with status : SUCCESS
java.lang.NullPointerExceptionSetting status of 13d7db3ebef77102f9441f403cd7bcf2443acfe6 to SUCCESS with url https://kibana-ci.elastic.co/job/elastic-kibana-pull-request/277/ and message: 'Build finished. '
Using context: kibana-ci
Could not update commit status of the Pull Request on GitHub.
java.net.SocketTimeoutException: connect timed out

ppisljar · 2016-08-02T11:57:04Z

latest version of chromedriver seems to fix this issue ... upgrading to latest (2.22.1)

Bargs · 2016-08-03T15:23:58Z

I ran into the same problem during testing yesterday, and upgrading to 2.22.1 worked for me as well. LGTM

LeeDr · 2016-08-03T17:22:09Z

LGTM

--------- **Commit 1:** downgrading chromedriver * Original sha: 13d7db3 * Authored by ppisljar <peter.pisljar@gmail.com> on 2016-07-27T15:18:03Z **Commit 2:** upgrading chromedriver to latest version * Original sha: 0a1838e * Authored by ppisljar <peter.pisljar@gmail.com> on 2016-08-02T11:55:47Z

[backport] PR #7859 to 4.x - Bump chromedriver

--------- **Commit 1:** downgrading chromedriver * Original sha: 13d7db3 * Authored by ppisljar <peter.pisljar@gmail.com> on 2016-07-27T15:18:03Z **Commit 2:** upgrading chromedriver to latest version * Original sha: 0a1838e * Authored by ppisljar <peter.pisljar@gmail.com> on 2016-08-02T11:55:47Z

[backport] PR #7859 to 4.5

upgrade chromedriver 2.21.2 -> 2.22.1 Former-commit-id: a7942b1

`v95.2.0`⏩`v95.3.0` _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- ## [`v95.3.0`](https://github.com/elastic/eui/releases/v95.3.0) - Updated `EuiThemeProvider`s to allow modifying/setting custom `breakpoint`s in nested usage (as opposed to only at the top `EuiProvider` level) ([#7862](elastic/eui#7862)) **Bug fixes** - Fixed a Chrome/Edge CSS `mask-image` bug that was affecting scroll overflow shadow utilties ([#7855](elastic/eui#7855)) **CSS-in-JS conversions** - Converted `EuiColorPicker` to Emotion; Removed `$euiColorPickerWidth` ([#7845](elastic/eui#7845)) - Converted `EuiColorPickerSwatch` to Emotion ([#7853](elastic/eui#7853)) - Converted `EuiColorPalettePicker` and `EuiColorPaletteDisplay` to Emotion ([#7854](elastic/eui#7854)) - Removed `$euiColorPaletteDisplaySizes` - Removed `@mixin euiColorPaletteInnerBorder` - Removed `$euiColorPickerValueRange0`, `$euiColorPickerValueRange1`, `$euiColorPickerSaturationRange0`, `$euiColorPickerSaturationRange1`, and `$euiColorPickerIndicatorSize` ([#7859](elastic/eui#7859)) **Accessibility** - Updated the `aria-label` attribute for the `EuiFilePicker` remove file button ([#7860](elastic/eui#7860)) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

`v95.2.0`⏩`v95.3.0` _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- - Updated `EuiThemeProvider`s to allow modifying/setting custom `breakpoint`s in nested usage (as opposed to only at the top `EuiProvider` level) ([elastic#7862](elastic/eui#7862)) **Bug fixes** - Fixed a Chrome/Edge CSS `mask-image` bug that was affecting scroll overflow shadow utilties ([elastic#7855](elastic/eui#7855)) **CSS-in-JS conversions** - Converted `EuiColorPicker` to Emotion; Removed `$euiColorPickerWidth` ([elastic#7845](elastic/eui#7845)) - Converted `EuiColorPickerSwatch` to Emotion ([elastic#7853](elastic/eui#7853)) - Converted `EuiColorPalettePicker` and `EuiColorPaletteDisplay` to Emotion ([elastic#7854](elastic/eui#7854)) - Removed `$euiColorPaletteDisplaySizes` - Removed `@mixin euiColorPaletteInnerBorder` - Removed `$euiColorPickerValueRange0`, `$euiColorPickerValueRange1`, `$euiColorPickerSaturationRange0`, `$euiColorPickerSaturationRange1`, and `$euiColorPickerIndicatorSize` ([elastic#7859](elastic/eui#7859)) **Accessibility** - Updated the `aria-label` attribute for the `EuiFilePicker` remove file button ([elastic#7860](elastic/eui#7860)) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

downgrading chromedriver

13d7db3

ppisljar added the review label Jul 27, 2016

ppisljar assigned LeeDr Jul 27, 2016

LeeDr changed the title ~~downgrading chromedriver~~ downgrading chromedriver 2.21.2 -> 2.18.0 Aug 1, 2016

upgrading chromedriver to latest version

0a1838e

LeeDr changed the title ~~downgrading chromedriver 2.21.2 -> 2.18.0~~ upgrade chromedriver 2.21.2 -> 2.22.1 Aug 3, 2016

LeeDr merged commit a7942b1 into elastic:master Aug 3, 2016

ppisljar deleted the downgradeChromeDriver branch August 4, 2016 05:40

LeeDr added the v5.0.0-alpha5 label Aug 17, 2016

This was referenced Aug 17, 2016

[backport] PR #7859 to 4.5 #8015

Closed

[backport] PR #7859 to 4.x - Bump chromedriver #8016

Merged

epixa added v4.6.0 v4.5.5 labels Aug 17, 2016

epixa added a commit that referenced this pull request Aug 18, 2016

Merge pull request #8016 from elastic/jasper/backport/7859/4.x

73f8513

[backport] PR #7859 to 4.x - Bump chromedriver

elastic-jasper mentioned this pull request Aug 18, 2016

[backport] PR #7859 to 4.5 #8025

Merged

epixa added a commit that referenced this pull request Aug 18, 2016

Merge pull request #8025 from elastic/jasper/backport/7859/8016/4.5

8c99184

[backport] PR #7859 to 4.5

airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017

Merge pull request elastic#7859 from ppisljar/downgradeChromeDriver

9244c30

upgrade chromedriver 2.21.2 -> 2.22.1 Former-commit-id: a7942b1

elasticmachine unassigned LeeDr Oct 29, 2024

Conversation

ppisljar commented Jul 27, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ppisljar commented Jul 28, 2016

Uh oh!

ppisljar commented Jul 28, 2016

Uh oh!

LeeDr commented Jul 28, 2016

Uh oh!

LeeDr commented Jul 29, 2016

Uh oh!

LeeDr commented Aug 1, 2016

Uh oh!

LeeDr commented Aug 1, 2016

Uh oh!

LeeDr commented Aug 1, 2016

Uh oh!

LeeDr commented Aug 1, 2016

Uh oh!

LeeDr commented Aug 1, 2016

Uh oh!

ppisljar commented Aug 1, 2016

Uh oh!

LeeDr commented Aug 1, 2016

Uh oh!

ppisljar commented Aug 2, 2016

Uh oh!

Bargs commented Aug 3, 2016

Uh oh!

LeeDr commented Aug 3, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ppisljar commented Jul 27, 2016 •

edited

Loading