Add new float support to console autocomplete#7853
Merged
Bargs merged 1 commit intoelastic:masterfrom Jul 27, 2016
Merged
Conversation
Elasticsearch added a couple new data types, half_float and scaled_float, so we should include those in Console's autocomplete suggestions for mappings. Scaled_float also has a required parameter called scaling_factor, which we suggest a sensible default for when autocompleted. We talked about leaving the value empty, forcing the user to pick a value, but the autocompleter doesn't seem to support blank values. Fixes: elastic#7811 Related: elastic#7782
Contributor
Author
|
@ycombinator I couldn't figure out a way to autocomplete a blank value, so I went with Adrien's suggestion for a good default value. |
Contributor
|
Just tested this out. Functionality looks good. Reviewing code now... |
Contributor
|
"Code" looks good too :) LGTM. |
Contributor
Author
|
@ppisljar could you give this a second set of eyes for me? |
Contributor
|
LGTM one question however, wouldnt be a good idea to automatically add the required parameters ? |
Contributor
Author
|
That's a good point @ppisljar, I'm not sure if it's possible with the current autocomplete DSL though. Do you have any idea @ycombinator ? |
Contributor
|
Yeah, that would be nice but I'm not sure what might be involved in implementing it within the current constraints. FWIW, I don't recall seeing this sort of behavior in Sense/Console before. |
Contributor
Author
|
Thanks for the input. I looked around myself and I couldn't find any existing examples of this sort of autocomplete. Gonna merge as is. |
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
Add new float support to console autocomplete Former-commit-id: 5ba2c18
tkajtoch
added a commit
that referenced
this pull request
Jul 13, 2024
`v95.2.0`⏩`v95.3.0` _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- ## [`v95.3.0`](https://github.com/elastic/eui/releases/v95.3.0) - Updated `EuiThemeProvider`s to allow modifying/setting custom `breakpoint`s in nested usage (as opposed to only at the top `EuiProvider` level) ([#7862](elastic/eui#7862)) **Bug fixes** - Fixed a Chrome/Edge CSS `mask-image` bug that was affecting scroll overflow shadow utilties ([#7855](elastic/eui#7855)) **CSS-in-JS conversions** - Converted `EuiColorPicker` to Emotion; Removed `$euiColorPickerWidth` ([#7845](elastic/eui#7845)) - Converted `EuiColorPickerSwatch` to Emotion ([#7853](elastic/eui#7853)) - Converted `EuiColorPalettePicker` and `EuiColorPaletteDisplay` to Emotion ([#7854](elastic/eui#7854)) - Removed `$euiColorPaletteDisplaySizes` - Removed `@mixin euiColorPaletteInnerBorder` - Removed `$euiColorPickerValueRange0`, `$euiColorPickerValueRange1`, `$euiColorPickerSaturationRange0`, `$euiColorPickerSaturationRange1`, and `$euiColorPickerIndicatorSize` ([#7859](elastic/eui#7859)) **Accessibility** - Updated the `aria-label` attribute for the `EuiFilePicker` remove file button ([#7860](elastic/eui#7860)) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
cee-chen
pushed a commit
to cee-chen/kibana
that referenced
this pull request
Sep 12, 2024
`v95.2.0`⏩`v95.3.0` _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- - Updated `EuiThemeProvider`s to allow modifying/setting custom `breakpoint`s in nested usage (as opposed to only at the top `EuiProvider` level) ([elastic#7862](elastic/eui#7862)) **Bug fixes** - Fixed a Chrome/Edge CSS `mask-image` bug that was affecting scroll overflow shadow utilties ([elastic#7855](elastic/eui#7855)) **CSS-in-JS conversions** - Converted `EuiColorPicker` to Emotion; Removed `$euiColorPickerWidth` ([elastic#7845](elastic/eui#7845)) - Converted `EuiColorPickerSwatch` to Emotion ([elastic#7853](elastic/eui#7853)) - Converted `EuiColorPalettePicker` and `EuiColorPaletteDisplay` to Emotion ([elastic#7854](elastic/eui#7854)) - Removed `$euiColorPaletteDisplaySizes` - Removed `@mixin euiColorPaletteInnerBorder` - Removed `$euiColorPickerValueRange0`, `$euiColorPickerValueRange1`, `$euiColorPickerSaturationRange0`, `$euiColorPickerSaturationRange1`, and `$euiColorPickerIndicatorSize` ([elastic#7859](elastic/eui#7859)) **Accessibility** - Updated the `aria-label` attribute for the `EuiFilePicker` remove file button ([elastic#7860](elastic/eui#7860)) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Elasticsearch added a couple new data types, half_float and
scaled_float, so we should include those in Console's autocomplete
suggestions for mappings. Scaled_float also has a required parameter
called scaling_factor, which we suggest a sensible default for when
autocompleted. We talked about leaving the value empty, forcing the user
to pick a value, but the autocompleter doesn't seem to support blank
values.
Fixes: #7811
Related: #7782