Upgrade EUI to v95.3.0 by tkajtoch · Pull Request #187342 · elastic/kibana

tkajtoch · 2024-07-02T10:49:36Z

v95.2.0⏩v95.3.0

Questions? Please see our Kibana upgrade FAQ.

`v95.3.0`

Updated EuiThemeProviders to allow modifying/setting custom breakpoints in nested usage (as opposed to only at the top EuiProvider level) (#7862)

Bug fixes

Fixed a Chrome/Edge CSS mask-image bug that was affecting scroll overflow shadow utilties (#7855)

CSS-in-JS conversions

Converted EuiColorPicker to Emotion; Removed $euiColorPickerWidth (#7845)
Converted EuiColorPickerSwatch to Emotion (#7853)
Converted EuiColorPalettePicker and EuiColorPaletteDisplay to Emotion (#7854)
- Removed $euiColorPaletteDisplaySizes
- Removed @mixin euiColorPaletteInnerBorder
Removed $euiColorPickerValueRange0, $euiColorPickerValueRange1, $euiColorPickerSaturationRange0, $euiColorPickerSaturationRange1, and $euiColorPickerIndicatorSize (#7859)

Accessibility

Updated the aria-label attribute for the EuiFilePicker remove file button (#7860)

tkajtoch · 2024-07-02T12:21:26Z

buildkite test this

…-fix'

kibana-ci · 2024-07-02T13:22:04Z

💔 Build Failed

Failed CI Steps

Test Failures

[job] [logs] FTR Configs #58 / @skipInServerless endpoint @ess @serverless For each artifact list under management When on the Event Filters entries list should be able to update an existing Event Filters entry

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`alerting`	91.5KB	91.5KB	+48.0B
`dashboard`	503.6KB	503.7KB	+48.0B
`discover`	809.4KB	809.5KB	+96.0B
`infra`	1.5MB	1.5MB	+193.0B
`kubernetesSecurity`	212.0KB	212.2KB	+192.0B
`lens`	1.5MB	1.5MB	+96.0B
`maps`	3.0MB	3.0MB	+241.0B
`ml`	4.6MB	4.6MB	+96.0B
`observability`	365.7KB	365.8KB	+48.0B
`security`	587.9KB	588.0KB	+48.0B
`securitySolution`	15.6MB	15.6MB	+96.0B
`slo`	871.0KB	871.1KB	+48.0B
`spaces`	180.6KB	180.6KB	+48.0B
`unifiedSearch`	221.5KB	221.6KB	+48.0B
`visTypeVega`	1.8MB	1.8MB	+192.0B
total			+1.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`core`	417.5KB	417.6KB	+107.0B
`kbnUiSharedDeps-css`	212.7KB	206.6KB	-6.1KB
`kbnUiSharedDeps-npmDll`	6.0MB	6.0MB	+6.2KB
`triggersActionsUi`	114.5KB	114.6KB	+48.0B
total			+213.0B

History

💔 Build #219058 failed 6d894ee

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @tkajtoch

asharma-5 · 2024-07-08T10:15:32Z

@tkajtoch this fix will be available in version 8.15.0 ? when can we expect this release?

elasticmachine · 2024-07-08T13:13:59Z

Pinging @elastic/eui-team (EUI)

jbudz

src/dev/license_checker/config.ts

jloleysens · 2024-07-09T08:46:03Z

packages/core/i18n/core-i18n-browser-internal/src/i18n_eui_mapping.tsx

+    'euiFilePicker.removeSelectedAriaLabel': i18n.translate(
+      'core.euiFilePicker.removeSelectedAriaLabel',
+      {
+        defaultMessage: 'Remove selected files',


Why was this copy changed from Clear to Remove? I don't think this functionality deletes anything.

That change comes from elastic/eui#7860 and originated in https://github.com/elastic/observability-dev/issues/3641.

The Remove EuiFilePicker button previously had an ARIA label, Clear selected files, that didn't match the button's displayed label. Now, the ARIA label matches the display label better. I agree that the usage of remove here could sometimes be misleading, but considering this button is only visible when you select a file from disk, it does make sense.

elasticmachine · 2024-07-10T13:01:53Z

⏳ Build in-progress, with failures

Buildkite Build
Commit: 2265c3a

Failed CI Steps

Test Failures

[job] [logs] Defend Workflows Cypress Tests on Serverless #4 / Automated Response Actions From alerts "before all" hook for "should have generated endpoint and rule" "before all" hook for "should have generated endpoint and rule"
[job] [logs] Defend Workflows Cypress Tests on Serverless #1 / Endpoint generated alerts "before each" hook for "should create a Detection Engine alert from an endpoint alert" "before each" hook for "should create a Detection Engine alert from an endpoint alert"
[job] [logs] Defend Workflows Cypress Tests on Serverless #7 / Endpoints page "before all" hook for "Shows endpoint on the list" "before all" hook for "Shows endpoint on the list"
[job] [logs] Defend Workflows Cypress Tests on Serverless #14 / Response console Execute operations: "before all" hook for ""execute --command" - should execute a command" "before all" hook for ""execute --command" - should execute a command"
[job] [logs] Defend Workflows Cypress Tests on Serverless #1 / Response console File operations: "before all" hook for ""get-file --path" - should retrieve a file" "before all" hook for ""get-file --path" - should retrieve a file"
[job] [logs] Defend Workflows Cypress Tests on Serverless #4 / Response console Host Isolation: "before all" hook for "should release an isolated host via response console" "before all" hook for "should release an isolated host via response console"
[job] [logs] Defend Workflows Cypress Tests on Serverless #5 / Response console Scan operation: "before all" hook for ""scan --path" - should scan a file" "before all" hook for ""scan --path" - should scan a file"

History

💔 Build #219302 failed 8a73f03

cc @tkajtoch

tkajtoch · 2024-07-11T10:40:57Z

@elasticmachine merge upstream

`v95.2.0`⏩`v95.3.0` _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- - Updated `EuiThemeProvider`s to allow modifying/setting custom `breakpoint`s in nested usage (as opposed to only at the top `EuiProvider` level) ([elastic#7862](elastic/eui#7862)) **Bug fixes** - Fixed a Chrome/Edge CSS `mask-image` bug that was affecting scroll overflow shadow utilties ([elastic#7855](elastic/eui#7855)) **CSS-in-JS conversions** - Converted `EuiColorPicker` to Emotion; Removed `$euiColorPickerWidth` ([elastic#7845](elastic/eui#7845)) - Converted `EuiColorPickerSwatch` to Emotion ([elastic#7853](elastic/eui#7853)) - Converted `EuiColorPalettePicker` and `EuiColorPaletteDisplay` to Emotion ([elastic#7854](elastic/eui#7854)) - Removed `$euiColorPaletteDisplaySizes` - Removed `@mixin euiColorPaletteInnerBorder` - Removed `$euiColorPickerValueRange0`, `$euiColorPickerValueRange1`, `$euiColorPickerSaturationRange0`, `$euiColorPickerSaturationRange1`, and `$euiColorPickerIndicatorSize` ([elastic#7859](elastic/eui#7859)) **Accessibility** - Updated the `aria-label` attribute for the `EuiFilePicker` remove file button ([elastic#7860](elastic/eui#7860)) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

kibanamachine · 2024-09-12T19:09:25Z

💔 All backports failed

Status	Branch	Result
❌	8.15	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 187342

Questions ?

Please refer to the Backport tool documentation

kibanamachine · 2024-09-12T19:11:28Z

💔 All backports failed

Status	Branch	Result
❌	8.15	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 187342

Questions ?

Please refer to the Backport tool documentation

## Backport This is a manual backport of EUI v95.3.0 (#187342) which was intended to target 8.15 but was missed due to the `backport:skip` label. The release contains a requested visual bugfix for Chromium users: elastic/eui#7855 (comment) Co-authored-by: Tomasz Kajtoch <tomasz.kajtoch@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

chore: upgrade @elastic/eui to v95.3.0

6d894ee

tkajtoch self-assigned this Jul 2, 2024

tkajtoch added backport:skip This PR does not require backporting EUI release_note:skip Skip the PR/issue when compiling release notes v8.15.0 labels Jul 2, 2024

tkajtoch added 2 commits July 2, 2024 13:48

chore: update i18n

48cc12a

test: update import_data_model snapshot

0918183

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

cd8677d

…-fix'

tkajtoch added 2 commits July 3, 2024 10:22

Merge branch 'main' into feat/eui-v95.3.0

8a73f03

Merge branch 'main' into feat/eui-v95.3.0

aeef939

Merge branch 'main' into feat/eui-v95.3.0

bc6729a

tkajtoch marked this pull request as ready for review July 8, 2024 13:13

tkajtoch requested review from a team as code owners July 8, 2024 13:13

jbudz approved these changes Jul 8, 2024

View reviewed changes

jloleysens reviewed Jul 9, 2024

View reviewed changes

Merge branch 'main' into feat/eui-v95.3.0

2265c3a

Merge branch 'main' into feat/eui-v95.3.0

93bbf4a

andrew-goldstein approved these changes Jul 11, 2024

View reviewed changes

tkajtoch enabled auto-merge (squash) July 11, 2024 14:41

Merge remote-tracking branch 'upstream/main' into feat/eui-v95.3.0

e5d155f

afharo approved these changes Jul 13, 2024

View reviewed changes

tkajtoch merged commit c299737 into elastic:main Jul 13, 2024

kibanamachine added the v8.16.0 label Jul 13, 2024

mbondyra mentioned this pull request Jul 16, 2024

[Vis-editor] Kibana displays a huge flyout when user clicks on any of the field configuration options on edit visualization panel #188330

Closed

This was referenced Jul 22, 2024

[Search] [Getting Started Guide] Update examples #188642

Merged

BedrockChat & GeminiChat #186809

Merged

Update dependency @redocly/cli to ^1.18.0 (main) #188721

Merged

kibanamachine mentioned this pull request Jul 29, 2024

Update dependency @redocly/cli to ^1.18.1 (main) #189401

Merged

1 task

kibanamachine mentioned this pull request Aug 8, 2024

Update dependency @launchdarkly/node-server-sdk to ^9.5.0 (main) #190101

Merged

1 task

cee-chen removed the backport:skip This PR does not require backporting label Sep 12, 2024

cee-chen mentioned this pull request Sep 12, 2024

Chromium workaround for CSS mask-image bug elastic/eui#7855

Merged

6 tasks

cee-chen mentioned this pull request Sep 12, 2024

[8.15] Upgrade EUI to v95.3.0 (#187342) #192764

Merged

cee-chen added backport:version Backport to applied version labels backport:prev-minor labels Sep 12, 2024

cee-chen removed the backport:version Backport to applied version labels label Sep 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade EUI to v95.3.0#187342

Upgrade EUI to v95.3.0#187342
tkajtoch merged 10 commits intoelastic:mainfrom
tkajtoch:feat/eui-v95.3.0

tkajtoch commented Jul 2, 2024 •

edited by kibanamachine

Loading

Uh oh!

tkajtoch commented Jul 2, 2024

Uh oh!

kibana-ci commented Jul 2, 2024 •

edited

Loading

Uh oh!

asharma-5 commented Jul 8, 2024 •

edited

Loading

Uh oh!

elasticmachine commented Jul 8, 2024

Uh oh!

jbudz left a comment

Uh oh!

jloleysens Jul 9, 2024

Uh oh!

tkajtoch Jul 9, 2024

Uh oh!

elasticmachine commented Jul 10, 2024 •

edited

Loading

Uh oh!

tkajtoch commented Jul 11, 2024

Uh oh!

kibanamachine commented Sep 12, 2024

Uh oh!

kibanamachine commented Sep 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Conversation

tkajtoch commented Jul 2, 2024 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

v95.3.0

Uh oh!

tkajtoch commented Jul 2, 2024

Uh oh!

kibana-ci commented Jul 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💔 Build Failed

Failed CI Steps

Test Failures

Metrics [docs]

Async chunks

Page load bundle

History

Uh oh!

asharma-5 commented Jul 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Jul 8, 2024

Uh oh!

jbudz left a comment

Choose a reason for hiding this comment

Uh oh!

jloleysens Jul 9, 2024

Choose a reason for hiding this comment

Uh oh!

tkajtoch Jul 9, 2024

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Jul 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

History

Uh oh!

tkajtoch commented Jul 11, 2024

Uh oh!

kibanamachine commented Sep 12, 2024

💔 All backports failed

Manual backport

Questions ?

Uh oh!

kibanamachine commented Sep 12, 2024

💔 All backports failed

Manual backport

Questions ?

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

tkajtoch commented Jul 2, 2024 •

edited by kibanamachine

Loading

`v95.3.0`

kibana-ci commented Jul 2, 2024 •

edited

Loading

asharma-5 commented Jul 8, 2024 •

edited

Loading

elasticmachine commented Jul 10, 2024 •

edited

Loading