Merged
Conversation
The latest version fixes a problem where you would get a bunch of warnings that you couldn't turn off if you used `render` instead of component with a route. This was causing us to use `component` in some places where `render` should be used. The latest version fixes this problem so we change back to `render` where appropriate. Also make our `ApmRoute` a `Route` instead of `any`.
Contributor
|
Pinging @elastic/apm-ui (Team:apm) |
ogupte
reviewed
Sep 22, 2020
| // This warning cannot be turned off | ||
| // (see https://github.com/elastic/apm-agent-rum-js/issues/881) so while this is | ||
| // slightly more code, it provides better performance without causing console | ||
| // warnings to appear. |
Contributor
There was a problem hiding this comment.
It's possible to not inline the redirects and continue to use component for the RUM agent. It would be a lot of boilerplate, but we could make it work:
const RedirectToServices = renderAsRedirectTo('/services');
...
{
component: RedirectToServices,
}
Contributor
Author
There was a problem hiding this comment.
We don't need to though. The problem with using render is the mounting/unmounting, which doesn't matter as much when we're just doing a redirect.
Contributor
💚 Build SucceededBuild metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
ogupte
approved these changes
Sep 22, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Sep 23, 2020
* master: (31 commits) skip tests for old pacakge (elastic#78194) [Ingest Pipelines] Add url generator for ingest pipelines app (elastic#77872) [Lens] Rename "telemetry" to "stats" (elastic#78125) [CSM] Url search (elastic#77516) [Drilldowns] Config to disable URL Drilldown (elastic#77887) [Lens] Combined histogram/range aggregation for numbers (elastic#76121) Remove legacy plugins support (elastic#77599) 'Auto' interval must be correctly calculated for natural numbers (elastic#77995) [CSM] fix ingest data retry order messed up (elastic#78163) Add response status helpers (elastic#78006) Bump react-beautiful-dnd (elastic#78028) [Security Solution][Detection Engine] Bubbles up more error messages from ES queries to the UI (elastic#78004) Index pattern - refactor constructor (elastic#77791) Add `xpack.security.sameSiteCookies` to docker allow list (elastic#78192) Remove [key: string]: any; from IIndexPattern (elastic#77968) Remove requirement for manage_index_templates privilege for Index Management (elastic#77377) [Ingest Manager] Agent bulk actions UI (elastic#77690) [Metrics UI] Add inventory view timeline (elastic#77804) Reporting/Docs: Updates for setting to enable CSV Download (elastic#78101) Update to latest rum-react (elastic#78193) ...
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
smith
added a commit
to smith/kibana
that referenced
this pull request
Sep 24, 2020
* Update to latest rum-react The latest version fixes a problem where you would get a bunch of warnings that you couldn't turn off if you used `render` instead of component with a route. This was causing us to use `component` in some places where `render` should be used. The latest version fixes this problem so we change back to `render` where appropriate. Also make our `ApmRoute` a `Route` instead of `any`. # Conflicts: # x-pack/package.json # x-pack/plugins/apm/typings/apm_rum_react.d.ts # yarn.lock
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
smith
added a commit
that referenced
this pull request
Sep 28, 2020
The latest version fixes a problem where you would get a bunch of warnings that you couldn't turn off if you used `render` instead of component with a route. This was causing us to use `component` in some places where `render` should be used. The latest version fixes this problem so we change back to `render` where appropriate. Also make our `ApmRoute` a `Route` instead of `any`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest version fixes a problem where you would get a bunch of warnings that you couldn't turn off if you used
renderinstead of component with a route. This was causing us to usecomponentin some places whererendershould be used.The latest version fixes this problem so we change back to
renderwhere appropriate.
Also make our
ApmRouteaRouteinstead ofany.