Remove [key: string]: any; from IIndexPattern#77968
Merged
mattkime merged 8 commits intoelastic:masterfrom Sep 22, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
Contributor
|
Pinging @elastic/apm-ui (Team:apm) |
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
sorenlouv
approved these changes
Sep 21, 2020
nreese
approved these changes
Sep 21, 2020
Contributor
nreese
left a comment
There was a problem hiding this comment.
maps changes LGTM
code review
peteharverson
approved these changes
Sep 21, 2020
Contributor
peteharverson
left a comment
There was a problem hiding this comment.
Tested ML edit and LGTM
kertal
approved these changes
Sep 22, 2020
Member
kertal
left a comment
There was a problem hiding this comment.
KibanaApp owned code LGTM, just a single change of a time in one field, didn't test.
shahzad31
approved these changes
Sep 22, 2020
Contributor
shahzad31
left a comment
There was a problem hiding this comment.
Uptime changes LGTM !!
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
rylnd
approved these changes
Sep 22, 2020
Contributor
rylnd
left a comment
There was a problem hiding this comment.
Security Solution changes looks good (it's just a single test file and the test still passes); appreciate this fix!
mattkime
added a commit
to mattkime/kibana
that referenced
this pull request
Sep 22, 2020
* Remove [key: string]: any; from IIndexPattern # Conflicts: # docs/development/plugins/data/server/kibana-plugin-plugins-data-server.iindexpattern.md # src/plugins/data/server/server.api.md # src/plugins/index_pattern_management/public/components/edit_index_pattern/indexed_fields_table/indexed_fields_table.tsx # x-pack/plugins/reporting/server/export_types/csv_from_savedobject/lib/get_csv_job.ts
mattkime
added a commit
that referenced
this pull request
Sep 23, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Sep 23, 2020
* master: (31 commits) skip tests for old pacakge (elastic#78194) [Ingest Pipelines] Add url generator for ingest pipelines app (elastic#77872) [Lens] Rename "telemetry" to "stats" (elastic#78125) [CSM] Url search (elastic#77516) [Drilldowns] Config to disable URL Drilldown (elastic#77887) [Lens] Combined histogram/range aggregation for numbers (elastic#76121) Remove legacy plugins support (elastic#77599) 'Auto' interval must be correctly calculated for natural numbers (elastic#77995) [CSM] fix ingest data retry order messed up (elastic#78163) Add response status helpers (elastic#78006) Bump react-beautiful-dnd (elastic#78028) [Security Solution][Detection Engine] Bubbles up more error messages from ES queries to the UI (elastic#78004) Index pattern - refactor constructor (elastic#77791) Add `xpack.security.sameSiteCookies` to docker allow list (elastic#78192) Remove [key: string]: any; from IIndexPattern (elastic#77968) Remove requirement for manage_index_templates privilege for Index Management (elastic#77377) [Ingest Manager] Agent bulk actions UI (elastic#77690) [Metrics UI] Add inventory view timeline (elastic#77804) Reporting/Docs: Updates for setting to enable CSV Download (elastic#78101) Update to latest rum-react (elastic#78193) ...
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove
[key: string]: any;fromIIndexPattern, reduceIIndexPatternusage - its too ambiguous, confusingIndexPatternand data objects.