'Auto' interval must be correctly calculated for natural numbers#77995
Merged
alexwizp merged 5 commits intoelastic:masterfrom Sep 23, 2020
Merged
'Auto' interval must be correctly calculated for natural numbers#77995alexwizp merged 5 commits intoelastic:masterfrom
alexwizp merged 5 commits intoelastic:masterfrom
Conversation
aa2ea4f to
adc337e
Compare
adc337e to
b19bfb7
Compare
timroes
reviewed
Sep 21, 2020
src/plugins/data/common/search/aggs/buckets/lib/histogram_calculate_interval.ts
Outdated
Show resolved
Hide resolved
timroes
reviewed
Sep 21, 2020
6f61036 to
90618b8
Compare
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededBuild metricspage load bundle size
History
To update your PR or re-run it, just comment with: |
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Sep 23, 2020
…stic#77995) * 'Auto' interval must be correctly calculated for natural numbers * fix ts error * fix PR comments Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
alexwizp
added a commit
that referenced
this pull request
Sep 23, 2020
) (#78251) * 'Auto' interval must be correctly calculated for natural numbers * fix ts error * fix PR comments Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Sep 23, 2020
* master: (31 commits) skip tests for old pacakge (elastic#78194) [Ingest Pipelines] Add url generator for ingest pipelines app (elastic#77872) [Lens] Rename "telemetry" to "stats" (elastic#78125) [CSM] Url search (elastic#77516) [Drilldowns] Config to disable URL Drilldown (elastic#77887) [Lens] Combined histogram/range aggregation for numbers (elastic#76121) Remove legacy plugins support (elastic#77599) 'Auto' interval must be correctly calculated for natural numbers (elastic#77995) [CSM] fix ingest data retry order messed up (elastic#78163) Add response status helpers (elastic#78006) Bump react-beautiful-dnd (elastic#78028) [Security Solution][Detection Engine] Bubbles up more error messages from ES queries to the UI (elastic#78004) Index pattern - refactor constructor (elastic#77791) Add `xpack.security.sameSiteCookies` to docker allow list (elastic#78192) Remove [key: string]: any; from IIndexPattern (elastic#77968) Remove requirement for manage_index_templates privilege for Index Management (elastic#77377) [Ingest Manager] Agent bulk actions UI (elastic#77690) [Metrics UI] Add inventory view timeline (elastic#77804) Reporting/Docs: Updates for setting to enable CSV Download (elastic#78101) Update to latest rum-react (elastic#78193) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #78032
Summary
This PR based on #77023 (comment)
For cases (valid only for natural(integer) numbers) where the difference between the maximum and minimum is less than the MaxBars value, we set the float value. This is not correct, the value must be a natural number and equal to 1
Steps to reproduce:
kibana_sample_data_ecommercesample dataHistogramaggregation by day_of_week_i fieldActual:
Expected:
Checklist
Delete any items that are not applicable to this PR.
For maintainers