Skip to content

[Enterprise Search] Add flag to restrict width of layout#77539

Merged
scottybollinger merged 2 commits intoelastic:masterfrom
scottybollinger:scottybollinger/layout-width
Sep 15, 2020
Merged

[Enterprise Search] Add flag to restrict width of layout#77539
scottybollinger merged 2 commits intoelastic:masterfrom
scottybollinger:scottybollinger/layout-width

Conversation

@scottybollinger
Copy link
Copy Markdown
Contributor

@scottybollinger scottybollinger commented Sep 15, 2020

Summary

This PR adds a boolean flag to restrict the width of the Enterprise Search layout file for use in Workplace Search.

Usage

<Layout navigation={<WorkplaceSearchNav />} restrictWidth>
  ...
</Layout>

Before
_before

After
_after

Checklist

Delete any items that are not applicable to this PR.

@scottybollinger
[Enterprise Search] Add flag to restrict with of layout
9990627 
This PR adds a boolean flag to restrict the width of the Enterprise Search layout file for use in Workplace Search.
@scottybollinger scottybollinger added Feature:Plugins release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 15, 2020
@scottybollinger scottybollinger requested a review from a team September 15, 2020 19:29
@cee-chen
Copy link
Copy Markdown
Contributor

cee-chen commented Sep 15, 2020

LGTM - actually, I wonder if @daveyholler would prefer us to restrict width for App Search as well? 🤷 I can check with him here. If yes then maybe we don't need to make it a prop and can just set restrictWidth period

@cee-chen
Copy link
Copy Markdown
Contributor

cee-chen commented Sep 15, 2020

tl;dr from Davey - leave App Search as full-width for now, we'll re-evaluate in some of App Search's meatier pages like results settings

@cee-chen
Copy link
Copy Markdown
Contributor

cee-chen commented Sep 15, 2020 •
edited
Loading

@scottybollinger Can we add a quick test for this? (+ update the it renders test to provide a negative)

  it('renders', () => {
    const wrapper = shallow(<Layout navigation={null} />);

    expect(wrapper.find('.enterpriseSearchLayout')).toHaveLength(1);
    expect(wrapper.find(EuiPageBody).prop('restrictWidth')).toBeFalsy();
  });

  it('passes the restrictWidth prop', () => {
    const wrapper = shallow(<Layout navigation={null} restrictWidth />);

    expect(wrapper.find(EuiPageBody).prop('restrictWidth')).toEqual(true);
  });

cee-chen
cee-chen approved these changes Sep 15, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweeet, thanks Scotty!

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Sep 15, 2020

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
enterpriseSearch 430.1KB +61.0B 430.1KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@scottybollinger scottybollinger merged commit f0a547f into elastic:master Sep 15, 2020
@scottybollinger scottybollinger deleted the scottybollinger/layout-width branch September 15, 2020 21:47
@scottybollinger scottybollinger mentioned this pull request Sep 15, 2020
Merged
scottybollinger added a commit to scottybollinger/kibana that referenced this pull request Sep 15, 2020
@scottybollinger
[Enterprise Search] Add flag to restrict width of layout (elastic#77539)
b47e7c9 
* [Enterprise Search] Add flag to restrict with of layout

This PR adds a boolean flag to restrict the width of the Enterprise Search layout file for use in Workplace Search.

* Add tests
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 16, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ilm/data-tier…
4146ba2 
…s-for-710

* 'master' of github.com:elastic/kibana: (95 commits)
  log request body in new ES client (elastic#77150)
  use `navigateToUrl` to navigate to recent nav links (elastic#77446)
  Move core config service to `kbn/config` package (elastic#76874)
  [UBI] Copy license to /licenses folder (elastic#77563)
  Skip flaky Events Viewer Cypress test
  [Lens] Remove dynamic names in telemetry fields (elastic#76988)
  [Maps] Add DynamicStyleProperty#getMbPropertyName and DynamicStyleProperty#getMbPropertyValue (elastic#77366)
  [Enterprise Search] Add flag to restrict width of layout (elastic#77539)
  [Security Solutions][Cases - Timeline] Fix bug when adding a timeline to a case (elastic#76967)
  [Security Solution][Detections] Integration test for Editing a Rule (elastic#77090)
  [Ingest pipelines] Polish pipeline debugging workflow (elastic#76058)
  [@kbn/utils] Adds missing dependency (elastic#77536)
  Add the Enterprise Search logo to the Overview search result (elastic#77514)
  [Logs UI] [Metrics UI] Remove saved object field mappings (elastic#75482)
  [Security Solution][Exceptions] Exception modal bulk close option only closes alerts generated by same rule (elastic#77402)
  Adds @kbn/utils package (elastic#76518)
  Map layout changes (elastic#77132)
  [Security Solution] [Detections] EQL Rule Creation (elastic#76831)
  Adding test user to maps tests under documents source folder  (elastic#77245)
  Suppress error logs when clients connect over HTTP instead of HTTPS (elastic#77397)
  ...

# Conflicts:
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/index.ts
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/phases/warm_phase.tsx
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 16, 2020
@gmmorris
Merge branch 'master' into alerts/alerting-exempt-rbac-remnant
c051d65 
* master: (55 commits)
  [Grok] Fix missing error message in error toasts (elastic#77499)
  [Alerting] Exempt Alerts pre 7.10 from RBAC on their Action execution until updated (elastic#75563)
  [ML] fix type in apply_influencer_filters_action (elastic#77495)
  [Lens] create reusable component for filters and range aggregation (elastic#77453)
  fix eslint violations
  Collapse alert chart previews by default (elastic#77479)
  [ML] Fixing field caps wrapper endpoint (elastic#77546)
  showing service maps when filte by environment not defined (elastic#77483)
  [Lens] Settings panel redesign and separate settings per y axis (elastic#76373)
  log request body in new ES client (elastic#77150)
  use `navigateToUrl` to navigate to recent nav links (elastic#77446)
  Move core config service to `kbn/config` package (elastic#76874)
  [UBI] Copy license to /licenses folder (elastic#77563)
  Skip flaky Events Viewer Cypress test
  [Lens] Remove dynamic names in telemetry fields (elastic#76988)
  [Maps] Add DynamicStyleProperty#getMbPropertyName and DynamicStyleProperty#getMbPropertyValue (elastic#77366)
  [Enterprise Search] Add flag to restrict width of layout (elastic#77539)
  [Security Solutions][Cases - Timeline] Fix bug when adding a timeline to a case (elastic#76967)
  [Security Solution][Detections] Integration test for Editing a Rule (elastic#77090)
  [Ingest pipelines] Polish pipeline debugging workflow (elastic#76058)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 16, 2020
@gmmorris
Merge branch 'master' into actions/webhook-remove-header
7bfbad5 
* master: (54 commits)
  [Grok] Fix missing error message in error toasts (elastic#77499)
  [Alerting] Exempt Alerts pre 7.10 from RBAC on their Action execution until updated (elastic#75563)
  [ML] fix type in apply_influencer_filters_action (elastic#77495)
  [Lens] create reusable component for filters and range aggregation (elastic#77453)
  fix eslint violations
  Collapse alert chart previews by default (elastic#77479)
  [ML] Fixing field caps wrapper endpoint (elastic#77546)
  showing service maps when filte by environment not defined (elastic#77483)
  [Lens] Settings panel redesign and separate settings per y axis (elastic#76373)
  log request body in new ES client (elastic#77150)
  use `navigateToUrl` to navigate to recent nav links (elastic#77446)
  Move core config service to `kbn/config` package (elastic#76874)
  [UBI] Copy license to /licenses folder (elastic#77563)
  Skip flaky Events Viewer Cypress test
  [Lens] Remove dynamic names in telemetry fields (elastic#76988)
  [Maps] Add DynamicStyleProperty#getMbPropertyName and DynamicStyleProperty#getMbPropertyValue (elastic#77366)
  [Enterprise Search] Add flag to restrict width of layout (elastic#77539)
  [Security Solutions][Cases - Timeline] Fix bug when adding a timeline to a case (elastic#76967)
  [Security Solution][Detections] Integration test for Editing a Rule (elastic#77090)
  [Ingest pipelines] Polish pipeline debugging workflow (elastic#76058)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 16, 2020
@gmmorris
Merge branch 'master' into actions/test-connector
45a2dd5 
* master: (76 commits)
  Fixing service maps API test (elastic#77586)
  [Grok] Fix missing error message in error toasts (elastic#77499)
  [Alerting] Exempt Alerts pre 7.10 from RBAC on their Action execution until updated (elastic#75563)
  [ML] fix type in apply_influencer_filters_action (elastic#77495)
  [Lens] create reusable component for filters and range aggregation (elastic#77453)
  fix eslint violations
  Collapse alert chart previews by default (elastic#77479)
  [ML] Fixing field caps wrapper endpoint (elastic#77546)
  showing service maps when filte by environment not defined (elastic#77483)
  [Lens] Settings panel redesign and separate settings per y axis (elastic#76373)
  log request body in new ES client (elastic#77150)
  use `navigateToUrl` to navigate to recent nav links (elastic#77446)
  Move core config service to `kbn/config` package (elastic#76874)
  [UBI] Copy license to /licenses folder (elastic#77563)
  Skip flaky Events Viewer Cypress test
  [Lens] Remove dynamic names in telemetry fields (elastic#76988)
  [Maps] Add DynamicStyleProperty#getMbPropertyName and DynamicStyleProperty#getMbPropertyValue (elastic#77366)
  [Enterprise Search] Add flag to restrict width of layout (elastic#77539)
  [Security Solutions][Cases - Timeline] Fix bug when adding a timeline to a case (elastic#76967)
  [Security Solution][Detections] Integration test for Editing a Rule (elastic#77090)
  ...
scottybollinger added a commit that referenced this pull request Sep 16, 2020
@scottybollinger
[Enterprise Search] Add flag to restrict width of layout (#77539) (#7…
6144ab0 
…7552)

* [Enterprise Search] Add flag to restrict with of layout

This PR adds a boolean flag to restrict the width of the Enterprise Search layout file for use in Workplace Search.

* Add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cee-chen cee-chen cee-chen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature:Plugins release_note:skip Skip the PR/issue when compiling release notes v7.10.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@scottybollinger @cee-chen @kibanamachine